Skip to content

fix(install): create the PostgreSQL volume without --name #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldy505 merged 2 commits into from
Nov 6, 2026
Merged

fix(install): create the PostgreSQL volume without --name #4613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edb2171
fix(install): create the PostgreSQL volume without --name
pcbeingused333 Nov 4, 2026
5837b00
chore: remove unit test for postgres volume create (per review)
pcbeingused333 Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install/upgrade-postgres.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ if [[ -n "$($CONTAINER_ENGINE volume ls -q --filter name=sentry-postgres)" && "$

# Get rid of the old volume as we'll rename the new one to that
$CONTAINER_ENGINE volume rm sentry-postgres
$CONTAINER_ENGINE volume create --name sentry-postgres
$CONTAINER_ENGINE volume create sentry-postgres
# There's no rename volume in Docker so copy the contents from old to new name
# Also append the `host all all all trust` line as `tianon/postgres-upgrade:9.6-to-14`
# doesn't do that automatically.
Expand Down Expand Up @@ -74,7 +74,7 @@ if [[ "$postgres_version" == "14" ]]; then

echo "[2/2] pg_upgrade completed. Replacing the PostgreSQL 14 volume with PostgreSQL 18 data..."
$CONTAINER_ENGINE volume rm sentry-postgres
$CONTAINER_ENGINE volume create --name sentry-postgres
$CONTAINER_ENGINE volume create sentry-postgres
$CONTAINER_ENGINE run --rm -v sentry-postgres-new:/from -v sentry-postgres:/to alpine ash -ec \
"mkdir -p /to/18/docker; cp -av /from/. /to/18/docker; echo 'host all all all trust' >> /to/18/docker/pg_hba.conf"
$CONTAINER_ENGINE volume rm sentry-postgres-new
Expand Down
Loading