fix(hono): Allow passing env and fix type issues#19825
Open
fix(hono): Allow passing env and fix type issues#19825
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| expect(applySdkMetadataMock).toHaveBeenCalledTimes(1); | ||
| expect(applySdkMetadataMock).toHaveBeenCalledWith(options, 'hono'); | ||
| expect(applySdkMetadataMock).toHaveBeenCalledWith(options, 'hono', ['hono', 'cloudflare']); |
There was a problem hiding this comment.
No test for the new callback options feature
Low Severity
The primary feature of this fix PR — passing options as a callback function receiving env (the (env: E['Bindings']) => HonoOptions branch) — has no unit, integration, or e2e test covering it. All existing tests pass options as a plain object. There's no test verifying that when options is a function, it gets called with the env argument and its return value is used correctly.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some things in the Hono cloudflare export:
env@sentry/cloudflareCloses #19826 (added automatically)