Repository navigation
Document that SimpleStatsCounter.snapshot() may be inconsistent with concurrent updates - #8741
Closed
LubabaKhalid wants to merge 1 commit into
Closed
LubabaKhalid wants to merge 1 commit into
LubabaKhalid wants to merge 1 commit into
Conversation
…h concurrent updates. `SimpleStatsCounter` is documented as thread-safe, but it updates its counters independently and without locking, so a snapshot taken during an update can include part of it (for example, a load-success count without the corresponding load time). That's intentional for performance, so document it rather than adding synchronization.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
|
@kluever could you take a look? This adds the documentation you mentioned in the issue thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleStatsCounteris documented as thread-safe, but it updates its counters independently and without locking, so a snapshot taken during an update can include only part of it (for example, a load-success count without the corresponding load time). Since that's intentional for performance, this documents it rather than adding synchronization.Fixes #2230