Skip to content

feat: Update minimum Ruby to v3.2 and support v4.0 #33813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aandreassa wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −15
Open

feat: Update minimum Ruby to v3.2 and support v4.0 #33813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions google-cloud-trace/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,20 @@ end

gem "activerecord", ">= 5.0", "< 7.1.4"
gem "autotest-suffix", "~> 1.1"
gem "benchmark", "~> 0.5.0"
gem "cgi", "~> 0.5.0"
gem "faraday", ">= 1.3", "< 3"
gem "google-style", "~> 1.30.1"
gem "minitest", "~> 5.16"
gem "google-style", "~> 1.32.0"
gem "irb", "~> 1.17"
gem "minitest", "~> 6.0.2"
gem "minitest-autotest", "~> 1.0"
gem "minitest-focus", "~> 1.1"
gem "minitest-rg", "~> 5.2"
gem "minitest-focus", "~> 1.4"
gem "minitest-mock", "~> 5.27"
gem "minitest-rg", "~> 5.3"
gem "ostruct", "~> 0.5.5"
gem "railties", ">= 5.0", "< 7.1.4"
gem "rake"
gem "redcarpet", "~> 3.0"
gem "simplecov", "~> 0.9"
gem "redcarpet", "~> 3.6"
gem "simplecov", "~> 0.22"
gem "yard", "~> 0.9"
gem "yard-doctest" # , "~> 0.1.6"
2 changes: 1 addition & 1 deletion google-cloud-trace/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ end

## Supported Ruby Versions

This library is supported on Ruby 3.0+.
This library is supported on Ruby 3.2+.

Google provides official support for Ruby versions that are actively supported
by Ruby Core—that is, Ruby versions that are either in normal maintenance or
Expand Down
15 changes: 8 additions & 7 deletions google-cloud-trace/acceptance/trace/trace_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@
trace = wait_until do
tracer.get_trace orig_trace.trace_id
end
trace.must_equal orig_trace
_(trace).must_equal orig_trace
end

focus
it "writes traces and lists them" do
start_time = Time.now.utc - 2
trace1 = simple_trace
Expand All @@ -43,8 +44,8 @@
page_size: 4
res.size == 3 ? res : nil
end
all_results.to_a.must_equal [trace1, trace2, trace3]
all_results.results_pending?.must_equal false
_(all_results.to_a).must_equal [trace1, trace2, trace3]
_(all_results.results_pending?).must_equal false
page1 = wait_until do
res = tracer.list_traces start_time, end_time,
view: :COMPLETE,
Expand All @@ -53,11 +54,11 @@
page_size: 2
res.to_a == [trace1, trace2] ? res : nil
end
page1.to_a.must_equal [trace1, trace2]
page1.results_pending?.must_equal true
_(page1.to_a).must_equal [trace1, trace2]
_(page1.results_pending?).must_equal true
page2 = page1.next_page
page2.to_a.must_equal [trace3]
page2.results_pending?.must_equal false
_(page2.to_a).must_equal [trace3]
_(page2.results_pending?).must_equal false
end
end
end
2 changes: 1 addition & 1 deletion google-cloud-trace/google-cloud-trace.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |gem|
["OVERVIEW.md", "AUTHENTICATION.md", "INSTRUMENTATION.md", "LOGGING.md", "CONTRIBUTING.md", "TROUBLESHOOTING.md", "CHANGELOG.md", "CODE_OF_CONDUCT.md", "LICENSE", ".yardopts"]
gem.require_paths = ["lib"]

gem.required_ruby_version = ">= 3.0"
gem.required_ruby_version = ">= 3.2"

gem.add_dependency "google-cloud-core", "~> 1.5"
gem.add_dependency "stackdriver-core", "~> 1.3"
Expand Down
Loading