Repository navigation
docs(skill): describe the installer's Homebrew preference and HOTDATA_NO_BREW - #348
eddietejeda wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| { file = "skills/hotdata/subskills/search/SKILL.md", search = "^version: .+", replace = "version: {{version}}", exactly = 1 }, | ||
| { file = "skills/hotdata/subskills/analytics/SKILL.md", search = "^version: .+", replace = "version: {{version}}", exactly = 1 }, | ||
| { file = "skills/hotdata/subskills/geospatial/SKILL.md", search = "^version: .+", replace = "version: {{version}}", exactly = 1 }, | ||
| { file = ".claude-plugin/plugin.json", search = "\"version\": \"[^\"]+\"", replace = "\"version\": \"{{version}}\"", exactly = 1 }, |
There was a problem hiding this comment.
Blocking. Remove this replacement entry, or add .claude-plugin/plugin.json to the repo in the same PR.
The file .claude-plugin/plugin.json does not exist in this checkout. cargo-release reads every pre-release-replacements file before it bumps versions, and a missing file is a read error. The 0.43.0 cargo release run therefore aborts at the replacement step. This entry is also unrelated to the PR title, which describes a skill docs change.
| fi | ||
| done | ||
| if [ -f .claude-plugin/plugin.json ]; then | ||
| pv="$(jq -r .version .claude-plugin/plugin.json 2>/dev/null || true)" |
There was a problem hiding this comment.
nit: Move this plugin.json check into the PR that adds .claude-plugin/plugin.json (not blocking).
The check never runs today because the file does not exist. Also, 2>/dev/null || true hides a missing jq. When jq is missing, the error message reports "declares version" with an empty value instead of naming the missing tool.
| curl --proto '=https' --tlsv1.2 -LsSf https://github.com/hotdata-dev/hotdata-cli/releases/latest/download/install.sh | HOTDATA_NO_SKILLS=1 sh | ||
| ``` | ||
|
|
||
| (The `HOTDATA_NO_SKILLS=1` flag prevents duplicate skill installations when running inside the Claude Code plugin.) The installer uses Homebrew (`brew install hotdata-dev/tap/cli`) when `brew` is present; otherwise it places a prebuilt binary at `~/.hotdata/cli/hotdata`. `HOTDATA_NO_BREW=1` forces the prebuilt path. |
There was a problem hiding this comment.
super nit: Remove the phrase "Claude Code plugin", or add the plugin first (not blocking). The repo contains no .claude-plugin/ directory, so an agent reading this sentence has no plugin to match it to.
There was a problem hiding this comment.
Review
Blocking Issues
Cargo.toml:108adds apre-release-replacementsentry for.claude-plugin/plugin.json. That file does not exist in the repo. cargo-release fails when it cannot read a replacement file, so the 0.43.0 release aborts.
Action Required
Remove the .claude-plugin/plugin.json entry from Cargo.toml. As an alternative, commit .claude-plugin/plugin.json with a "version" field in this PR. The scripts/check-skills.sh plugin.json check belongs with the same change.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Closing: this PR accidentally included uncommitted plugin work-in-progress from the checkout. The branch is kept as-is for that work. Skill note resubmitted separately. |
1 participant
Skill follow-up for #347: the installer now prefers Homebrew and honors HOTDATA_NO_BREW=1. Unblocks the 0.43.0 skill-drift gate.