Repository navigation
docs(skill): describe the installer's Homebrew preference and HOTDATA_NO_BREW #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,6 +125,13 @@ if [ "$REQUIRE_VERSION" = 1 ]; then | |
| fail=1 | ||
| fi | ||
| done | ||
| if [ -f .claude-plugin/plugin.json ]; then | ||
| pv="$(jq -r .version .claude-plugin/plugin.json 2>/dev/null || true)" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Move this plugin.json check into the PR that adds The check never runs today because the file does not exist. Also, |
||
| if [ "$pv" != "$crate" ]; then | ||
| echo "error: .claude-plugin/plugin.json declares version $pv, Cargo.toml is $crate" >&2 | ||
| fail=1 | ||
| fi | ||
| fi | ||
| [ "$fail" = 0 ] && echo "→ skills: version ok ($crate)" | ||
| fi | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,16 @@ hotdata <command> [args] | |
|
|
||
| Or if installed on PATH: `hotdata <command> [args]` | ||
|
|
||
| ## Prerequisites: CLI installation | ||
|
|
||
| If the `hotdata` executable is not found on PATH or under `~/.hotdata/cli/`, prompt the user to install it: | ||
|
|
||
| ```sh | ||
| curl --proto '=https' --tlsv1.2 -LsSf https://github.com/hotdata-dev/hotdata-cli/releases/latest/download/install.sh | HOTDATA_NO_SKILLS=1 sh | ||
| ``` | ||
|
|
||
| (The `HOTDATA_NO_SKILLS=1` flag prevents duplicate skill installations when running inside the Claude Code plugin.) The installer uses Homebrew (`brew install hotdata-dev/tap/cli`) when `brew` is present; otherwise it places a prebuilt binary at `~/.hotdata/cli/hotdata`. `HOTDATA_NO_BREW=1` forces the prebuilt path. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. super nit: Remove the phrase "Claude Code plugin", or add the plugin first (not blocking). The repo contains no |
||
|
|
||
| ## Sub-skills (loaded on demand) | ||
|
|
||
| This is the only top-level hotdata skill. Three specialized guides ship **bundled inside it** under `subskills/` and are not separate skills — **`Read` the matching file only when the task needs it** (progressive disclosure), then follow it: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking. Remove this replacement entry, or add
.claude-plugin/plugin.jsonto the repo in the same PR.The file
.claude-plugin/plugin.jsondoes not exist in this checkout. cargo-release reads everypre-release-replacementsfile before it bumps versions, and a missing file is a read error. The 0.43.0cargo releaserun therefore aborts at the replacement step. This entry is also unrelated to the PR title, which describes a skill docs change.