Skip to content

[Vulcan] Check released history when the changelog is deleted - #371

Merged
iliaal merged 1 commit into
masterfrom
vulcan/changelog-deletion-guard
Nov 16, 2026
Merged

iliaal merged 1 commit into
masterfrom
vulcan/changelog-deletion-guard

Conversation

@iliaal

@iliaal iliaal commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Why

Deleting CHANGELOG.md bypassed the guard's released-history check: check_base() returned success as soon as the merged tree no longer contained the file. Emptying the same file was correctly rejected.

Change

Treat an absent changelog in the merged tree as empty content and apply the existing released-line comparison. The explicit changelog-override label still downgrades these findings to warnings; deletion of an unreleased-only changelog remains allowed. Add end-to-end fixtures for deletion, override, emptying, and unreleased-only deletion.

Validation

  • Baseline guard suite: 33 tests passed.
  • New deletion regression against original guard: failed as expected (guard incorrectly returned 0).
  • Updated guard suite: 36 tests passed; independently repeated with all 36 passing.
  • git diff --check: passed.
  • No PHP/LibXL runtime code or workflow permissions changed. PHP extension build not run locally for this Python-only fix; repository CI results will be checked on the published head.

This is separate from peer-check scheduling/concurrency behavior.

@iliaal
iliaal merged commit 79adbd4 into master Nov 16, 2026
39 checks passed
@iliaal
iliaal deleted the vulcan/changelog-deletion-guard branch November 16, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant