Repository navigation
[Vulcan] Check released history when the changelog is deleted - #371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deleting CHANGELOG.md bypassed the guard's released-history check:
check_base()returned success as soon as the merged tree no longer contained the file. Emptying the same file was correctly rejected.Change
Treat an absent changelog in the merged tree as empty content and apply the existing released-line comparison. The explicit
changelog-overridelabel still downgrades these findings to warnings; deletion of an unreleased-only changelog remains allowed. Add end-to-end fixtures for deletion, override, emptying, and unreleased-only deletion.Validation
git diff --check: passed.This is separate from peer-check scheduling/concurrency behavior.