Skip to content

components 0.5.5 (unpublished): Form.BusinessInfo asks the store address with Google's suggestions; portable deprecated - #205

Merged
joelmsanto merged 2 commits into
mainfrom
refactor/retirar-portable
Nov 8, 2026
Merged

joelmsanto merged 2 commits into
mainfrom
refactor/retirar-portable

Conversation

@joelmsanto

Copy link
Copy Markdown
Contributor

Owner, 2026-11-07. Plan «retire lib/portable», phase 2. Version 0.5.5, unpublished.

Merge after #204. This branch starts on #204's revert commit (d37541b). Once #204 is merged, this diff is only its own commit.

Form.BusinessInfo: the store address

  • While the form can be edited: the address is AutoCompleteInput (Google's suggestions), as the driver's operating address is: no GPS button, no «use my location» row.
    • The picked suggestion's description is reported as location; clearing it reports ''.
    • Its server errors are listed under it (FieldErrorText, error.location).
    • The server places it with the driver's geocoding and refuses one it cannot (operating_address_not_located, Firebase vendor/direccion-comercio).
  • Under readOnly (the console) or isDisabled (a locked store): the address stays the field it was, because the suggestions have no read-only state. Those renders are unchanged.

One entry

  • The barrel now serves ZOOM and useModalFocus, which only portable.js served, so a host can drop lib/portable.
  • portable.js is deprecated and goes in 0.6.0 (phase 5).
  • PROJECT.md says so and documents the address.

Not run

The owner decided (2026-11-07) that this phase goes without the library's own tests:

  • This repository cannot install: the root lock fails npm ci with ERESOLVE, as every CI run since 2026-09-18, so CI will be red. No test or lint ran; the changed files parse.
  • The pinned render «app path: Form.BusinessInfo (editable, server errors)» (legacyTrees.json) now differs on purpose: its address is the suggestions. It is recaptured when the suite can run again.
  • The test setup is unchanged: the barrel already loads under it (A-3).
  • The app verifies 0.5.5 once installed (plan phases 3, 4 and 6).

After merging

The owner publishes 0.5.5. The app then pins it and drops lib/portable (phase 3).

🤖 Generated with Claude Code

Joely and others added 2 commits November 7, 2026 14:34
…n, for a host that asks the address itself"

This reverts commit 8557b80.

It reached main without review: a VS Code sync on a branch that tracked
origin/main pushed it (2026-11-07). The owner then chose another design: the
store address is picked from Google's suggestions inside Form.BusinessInfo
itself, once the library has a single entry (plan: retire lib/portable). main
goes back to cf906c7, version 0.5.4, so nothing is published with
showLocation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ess with Google's suggestions; portable deprecated

Owner, 2026-11-07 (plan: retire lib/portable, phase 2).

- Form.BusinessInfo: while the form can be edited, the store address is
  AutoCompleteInput, as the driver's operating address is (no GPS button, no
  «use my location» row). The picked suggestion's description is reported as
  `location`, clearing it reports '', and its server errors are listed under
  it (FieldErrorText). The suggestions have no read-only state, so under
  readOnly (the console) or isDisabled (a locked store) the address stays the
  field it was, and those renders are unchanged.
- The barrel serves ZOOM and useModalFocus, which only portable.js served, so
  a host can drop lib/portable. portable.js is deprecated and goes in 0.6.0;
  PROJECT.md says so and documents the address.
- Story BusinessInfoReadOnly. Tests: the suggestions while editable, the field
  under readOnly and isDisabled, the address's error, and the barrel serving
  the two names.

NOT RUN (owner's decision, 2026-11-07): this repository cannot install (the
root lock fails with ERESOLVE, as every CI run since 2026-09-18), so no test or
lint ran; the changed files parse. The pinned render «app path:
Form.BusinessInfo (editable, server errors)» (legacyTrees.json) now differs on
purpose, the address being the suggestions; it is recaptured when the suite
can run again. The test setup is unchanged: the barrel already loads under it
(A-3). The app verifies this version once installed (plan phases 3, 4 and 6).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joelmsanto
joelmsanto merged commit 58bd16d into main Nov 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant