Skip to content

fix(ci): restore upgrade tests from RC3 (v1.0.x backport) - #3596

Closed
EItanya wants to merge 1 commit into
backport/v1.0.x/00-revert-3586from
backport/v1.0.x/01-3558
Closed

EItanya wants to merge 1 commit into
backport/v1.0.x/00-revert-3586from
backport/v1.0.x/01-3558

Conversation

@EItanya

@EItanya EItanya commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Upgrade tests on `main` now select `v1.0.0-rc3`, which already installs
Atelet as a separate Helm release. The regular upgrade test was blocked
by a missing optional migration table, then by missing Harness fixtures
when it tried to invoke the previous release.

Check for the optional tracking table in a separate statement:
PostgreSQL resolves table references before evaluating `CASE`. Keep
readiness polling for the required core migration table.

Before each invocation phase, apply the four Harness fixtures used by
`TestSessionInteraction` from the matching source checkout. Resolve
their images from the installed controller's runtime catalog so the
previous release, current build, and application rollback each exercise
their own runtime images. Reuse the existing lifecycle manifest without
creating its unrelated smoke Agents or opaque BYO fixture.

Validated with PostgreSQL query checks, fixture rendering tests for
released and locally built images, upgrade-package configuration tests,
and Go lint. Both required upgrade checks passed on `9bd2ab0fe`,
including invocation before and after the upgrade, schema comparison,
application rollback, and schema rollback.

<details>
<summary>Runtime fixtures across upgrade and rollback</summary>

```mermaid
flowchart LR
    source["Matching release or PR checkout"] -->|Lifecycle manifest| fixtures["Invocation Harness fixtures"]
    controller["Installed controller configuration"] -->|Runtime image digests| fixtures
    fixtures -->|Apply| cluster["Upgrade test cluster"]
    cluster -->|Invoke all four Harnesses| test["TestSessionInteraction"]
```

</details>

---------

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
(cherry picked from commit 2e2acf5)
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
@EItanya

EItanya commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the team decided to leave release/v1.0.x as it is for stability, so neither the revert of #3586 nor the re-stacked backports will land.

Comment left by Claude on behalf of @EItanya

@EItanya EItanya closed this Nov 9, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
github.com/kagent-dev/kagent/go/core/test/upgrade/TestUpgrade View Logs
github.com/kagent-dev/kagent/go/core/test/upgrade/TestUpgrade/apply_target_migrations View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@EItanya
EItanya deleted the backport/v1.0.x/01-3558 branch November 10, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant