Skip to content

refactor(api): move MCP header resolution out of v1alpha3 (v1.0.x backport) - #3600

Closed
EItanya wants to merge 1 commit into
backport/v1.0.x/04-3562from
backport/v1.0.x/05-3563
Closed

refactor(api): move MCP header resolution out of v1alpha3 (v1.0.x backport)#3600
EItanya wants to merge 1 commit into
backport/v1.0.x/04-3562from
backport/v1.0.x/05-3563

Conversation

@EItanya

@EItanya EItanya commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backports #3563 (c6adf72f9) to release/v1.0.x without modifications.

Stacked on backport/v1.0.x/04-3562. Merge it after the PR below it in the stack.

Stack (merge in order, bottom first):

  1. revert: undo squashed backport #3586 on v1.0.x #3595 revert of fix: backport pre-release fixes to v1.0.x #3586
  2. fix(ci): restore upgrade tests from RC3 (v1.0.x backport) #3596 backports fix(ci): restore upgrade tests from RC3 #3558
  3. fix(ui): show when the Substrate lists were read, not a running age (v1.0.x backport) #3597 backports fix(ui): show when the Substrate lists were read, not a running age #3545
  4. feat(session): revert crashed runtimes through RevertSession (v1.0.x backport) #3598 backports feat(session): revert crashed runtimes through RevertSession #3395
  5. refactor: Remove helpers orphaned by KMCP removal (v1.0.x backport) #3599 backports refactor: Remove helpers orphaned by KMCP removal #3562
  6. refactor(api): move MCP header resolution out of v1alpha3 (v1.0.x backport) #3600 backports refactor(api): move MCP header resolution out of v1alpha3 #3563
  7. fix(controller): move a ModelConfig condition's transition time only on a status change (v1.0.x backport) #3601 backports fix(controller): move a ModelConfig condition's transition time only on a status change #3340
  8. fix(adk): defer MCP tool discovery until invocation (v1.0.x backport) #3602 backports adk/mcp: defer tool discovery until invocation #3560

🤖 Generated with Claude Code

@timflannagan @EItanya
refactor(api): move MCP header resolution out of v1alpha3 (#3563)
02277ef 
# Description

`go/api/v1alpha3` is the public API that external clients and wrapper
types import, but it pulled in controller-runtime and `database/sql` for
a few helpers that do I/O. This moves those helpers out so the API
package only describes data.

`RemoteMCPServerSpec` loses its `sql.Scanner`/`driver.Valuer` methods,
which nothing used. `RemoteMCPServer.ResolveHeaders`,
`ValueRef.Resolve`, and `ValueSource.Resolve` move into the tool
service's MCP client, their only caller, and `go/api/utils` is removed.
The translator keeps its existing `HeadersFrom` handling, which compiles
Secret-backed headers into egress credentials rather than reading them.

Header resolution behaves the same, except errors are now wrapped and
name the failing header. Go consumers that called the removed methods
need to read the referenced Secret or ConfigMap themselves.

Signed-off-by: timflannagan <timflannagan@gmail.com>
(cherry picked from commit c6adf72)
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
@EItanya
EItanya requested a review from a team as a code owner November 9, 2026 18:21
This was referenced Nov 9, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@EItanya
EItanya added this pull request to stack #3603 November 9, 2026 18:22
@EItanya

EItanya commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the team decided to leave release/v1.0.x as it is for stability, so neither the revert of #3586 nor the re-stacked backports will land.

Comment left by Claude on behalf of @EItanya

@EItanya EItanya closed this Nov 9, 2026
@EItanya
EItanya deleted the backport/v1.0.x/05-3563 branch November 10, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EItanya @timflannagan