Skip to content

fix: move secret check from job-level to step-level in sync-dashboard-team#1912

Merged
gustavobtflores merged 1 commit into
kernelci:mainfrom
gustavobtflores:fix/sync-team-secret-check
May 20, 2026
Merged

fix: move secret check from job-level to step-level in sync-dashboard-team#1912
gustavobtflores merged 1 commit into
kernelci:mainfrom
gustavobtflores:fix/sync-team-secret-check

Conversation

@gustavobtflores
Copy link
Copy Markdown
Contributor

@gustavobtflores gustavobtflores commented May 20, 2026

Fix GitHub Actions workflow failure caused by using secrets.ORG_ADMIN_TOKEN in job-level if.

GitHub Actions does not allow secrets context in jobs.<job_id>.if, so PR validation now gates only on pull request event. Secret-dependent dry run step checks env.ORG_ADMIN_TOKEN instead.

Ref: https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-secrets#using-secrets-in-a-workflow

Copy link
Copy Markdown
Contributor

@alanpeixinho alanpeixinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gustavobtflores gustavobtflores added this pull request to the merge queue May 20, 2026
Merged via the queue into kernelci:main with commit 7314e3c May 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants