runtimes: fix path translation when using --device-dict#64
Closed
roxell wants to merge 1 commit into
Closed
Conversation
In device-dict mode the bind uses dispatcher_download_dir on both the host and the container. The docker wrapper rewrote mount sources to tmpdir/dispatcher/tmp instead. This sent the wrong path to the host docker daemon. The bind failed with: bind source path does not exist: ... Set _device_dict_volume to dispatcher_download_dir so the wrapper rewrite becomes a no-op in this mode. Also create the dispatcher_download_dir on the host before binding it. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Member
|
I don't see this issue on my side. Strange, what's your steps here to reproduce? |
Collaborator
Author
This is the failure. cmdline |
Member
|
Debugging this I see the issue is down to fastboot. Also be good to catch podman, I threw together a patch: https://gist.github.com/bhcopeland/8cc71b16bd93026b26faabd2d46e9565 |
Collaborator
Author
Great, send that as a PR and I review it, and we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In device-dict mode the bind uses dispatcher_download_dir on both the host and the container. The docker wrapper rewrote mount sources to tmpdir/dispatcher/tmp instead.
This sent the wrong path to the host docker daemon. The bind failed with:
bind source path does not exist: ...
Set _device_dict_volume to dispatcher_download_dir so the wrapper rewrite becomes a no-op in this mode.
Also create the dispatcher_download_dir on the host before binding it.