[kalasha] keyboard submission by Meng-Heng · Pull Request #3917 · keymanapp/keyboards

Meng-Heng · 2026-03-11T05:21:30Z

On behalf of Elsa Cooper and Malachi James.

Test-bot: skip

keyman-server · 2026-03-11T05:22:21Z

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

release/k/kalasha/source/kalasha.kps

Co-authored-by: Darcy Wong <darcy_wong@sil.org>

darcywong00

A few minor changes for the build to compile

release/k/kalasha/source/kalasha.kps

darcywong00 · 2026-03-12T03:18:46Z

release/k/kalasha/kalasha.keyboard_info

+        "kls"
+    ],
+	  "description": "The Kaḷaṣamondr keyboard is created to type the kalasha language with Roman (Latin) script. Allowing keyboard users to write in English and Kalasha without switching keyboards."
+}


I think you can remove .keyboard_info since kmc generates it now.

release/k/kalasha/source/welcome/welcome.htm

release/k/kalasha/source/kalasha.kmn

…kalasha_keyboard

…tions Co-Author-By: Darcy

…ards into kalasha_keyboard

LornaSIL · 2026-03-12T14:21:00Z

The kalasha.php file needs to have the style information inside the php header, not outside.
Use the $pagestyle setting something like the following. There are actually a lot of keyboards you can look at for a sample.

<?php 
  $pagename = 'Amazigh Latin (SIL) Keyboard Help';
  $pagetitle = $pagename;
  $pagestyle = <<<END
    samp {font-size:16pt; line-height:.8em;}
    kbd {color:black; font:9pt Arial; border:solid 1px grey; background:#ccc; margin:0px 1px;  padding:2px 4px; vertical-align:middle; line-height:2em; -webkit-border-radius: 3px; -moz-border-radius: 3px; border-radius: 3px;}
    table { border-collapse: collapse; width: 25%; font-size: small; }
    td, th { border: 1px solid #cccccc; text-align: left; padding: 5px; font: 12pt Tahoma;}
    tr:nth-child(even) { background-color: #eeeeee; }
    tr { height: 2.2em; }
END;
  
  require_once('header.php');
?>

Also, all graphics used in the php file must be in the help folder, not pulled from the welcome folder. This is because they help folder is actually copied into another repo at build time. So, it won't find those files the .php file is looking for. It's unfortunate they have to be duplicated in the repo, but that's the system for now.

LornaSIL · 2026-03-12T14:35:56Z

Keyboard name should be made consistent. Currently there is Kalasha and Kaḷaṣamondr in various files. (It is fine for the filename to be kalasha and the keyboard name to be Kaḷaṣamondr if that's what they want.)

As said above, LICENSE.md should be included on the Details tab of the .kps or it won't compile on the build system (it does compile locally, but the online build system is more strict).

LornaSIL · 2026-03-12T14:52:54Z

I double-checked the langtag and it is correctly kls for the Latin script for this language.

Meng-Heng · 2026-03-13T04:44:32Z

Keyboard name should be made consistent. Currently there is Kalasha and Kaḷaṣamondr in various files. (It is fine for the filename to be kalasha and the keyboard name to be Kaḷaṣamondr if that's what they want.)

Yes, I am considering to use the kalasha as the id and Kaḷaṣamondr for the name. The keyboard was sent to me like that. I'll update.

…s, and apply the style correctly Co-authored-by: Lorna

Meng-Heng · 2026-03-13T08:37:28Z

Also, all graphics used in the php file must be in the help folder, not pulled from the welcome folder. This is because they help folder is actually copied into another repo at build time.

I have two help/longpress.gif welcome/longpress.gif, do I need to add both files to KPS?

LornaSIL · 2026-03-13T14:19:04Z

I have two help/longpress.gif welcome/longpress.gif, do I need to add both files to KPS?

You need the one from welcome in the .kps. You shouldn't include anything from help (unless the welcome file is referencing those graphics in the help folder).

Meng-Heng · 2026-03-16T01:27:28Z

Thank you.

LornaSIL · 2026-03-17T21:50:08Z

Are you still working on this PR? It's still in draft.
Also, LICENSE.md should be referenced on the Details tab of the .kps. I don't think it s.

Meng-Heng · 2026-03-18T01:45:04Z

I am waiting on the keyboard authors to test the keyboard to see if it is the right behavior they are looking for.
Yes, sorry about that. I got confused between the Details and the File tabs.

darcywong00 · 2026-03-19T02:42:28Z

release/k/kalasha/source/help/kalasha.php

+  $pagestyle = <<<END
+        body {
+          font-family: Arial, Helvetica, sans-serif;
+          margin: 40px;


Might be able to remove the margin styling.
Otherwise the title bar gets

Suggested change

margin: 40px;

…kalasha_keyboard

mcdurdin · 2026-03-23T05:20:03Z

release/k/kalasha/source/help/kalasha.php

+        body {
+          font-family: Arial, Helvetica, sans-serif;
+          background: #f9f9f9;
+        }
+
+        table {
+          width: 100%;
+          border-collapse: collapse;
+          background: white;
+        }
+
+        thead.main-header, .main-foot {
+          background: #2c3e50;
+          color: white;
+        }
+
+        thead.sub-header {
+          background-color: #284a6e;
+          color: white;
+        }
+
+        th, td {
+          padding: 12px 16px;
+          text-align: left;
+          border-bottom: 1px solid #ddd;
+        }
+
+        th {
+          font-weight: 600;
+          letter-spacing: 0.02em;
+        }
+
+        tbody tr:hover {
+          background: #f5f7fa;
+        }
+
+        tbody tr:nth-child(even) {
+          background: #fafafa;
+        }
+
+        kbd {
+          font-size: 20px;
+          background-color: black;
+          color: white ;
+          border-radius: 20px;
+          text-align: center;
+          padding: 2px 25px;
+        }


These mostly should not be included here -- they are too broad. In particular, do not override styling for body.

To have styles that apply only to the keyboard section and not to the frame content, then use the tag article, for example:

article table { width: 100%; border-collapse: collapse; background: white; }

…kalasha_keyboard

[kalasha] keyboard submission

3fdca36

Meng-Heng marked this pull request as draft March 11, 2026 05:21

[kalasha] update welcome.htm

26bdbf3

darcywong00 reviewed Mar 11, 2026

View reviewed changes

release/k/kalasha/source/kalasha.kps Outdated Show resolved Hide resolved

Update release/k/kalasha/source/kalasha.kps

e4f42e2

Co-authored-by: Darcy Wong <darcy_wong@sil.org>

darcywong00 requested changes Mar 12, 2026

View reviewed changes

Meng-Heng added 3 commits March 12, 2026 16:29

Merge branch 'master' of https://github.com/keymanapp/keyboards into …

e4f2281

…kalasha_keyboard

[kalasha] adjust a few key rules from keyboad author and apply sugges…

d294897

…tions Co-Author-By: Darcy

Merge branch 'kalasha_keyboard' of https://github.com/Meng-Heng/keybo…

6582bc5

…ards into kalasha_keyboard

Meng-Heng marked this pull request as ready for review March 13, 2026 04:17

[kalasha] change flick gif, correct name and id locations on the file…

e77bdff

…s, and apply the style correctly Co-authored-by: Lorna

Meng-Heng marked this pull request as draft March 13, 2026 07:45

[kalasha] update longpress.gif in kps

376f273

[kalasha] add license file into details tab of kps

cae3dcc

darcywong00 reviewed Mar 19, 2026

View reviewed changes

Meng-Heng added 4 commits March 19, 2026 15:50

Merge branch 'master' of https://github.com/keymanapp/keyboards into …

f5adeb5

…kalasha_keyboard

Merge branch 'master' of https://github.com/keymanapp/keyboards into …

947b404

…kalasha_keyboard

[kalasha] update keyboard description, keys, styles, and version history

6472de9

[kalasha] detailing readme and welcome files

68b8865

mcdurdin reviewed Mar 23, 2026

View reviewed changes

Meng-Heng added 2 commits March 25, 2026 11:31

Merge branch 'master' of https://github.com/keymanapp/keyboards into …

5e429ab

…kalasha_keyboard

[kalasha] update styles for php

54fb577

darcywong00 mentioned this pull request Mar 26, 2026

[thai_kedmanee_mattix] Migrate keyboard from legacy/thai-uni #3926

Merged

3 tasks

Uh oh!

Conversation

Meng-Heng commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keyman-server commented Mar 11, 2026

Uh oh!

Uh oh!

darcywong00 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darcywong00 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LornaSIL commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LornaSIL commented Mar 12, 2026

Uh oh!

LornaSIL commented Mar 12, 2026

Uh oh!

Meng-Heng commented Mar 13, 2026

Uh oh!

Meng-Heng commented Mar 13, 2026

Uh oh!

LornaSIL commented Mar 13, 2026

Uh oh!

Meng-Heng commented Mar 16, 2026

Uh oh!

LornaSIL commented Mar 17, 2026

Uh oh!

Meng-Heng commented Mar 18, 2026

Uh oh!

darcywong00 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

mcdurdin Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Meng-Heng commented Mar 11, 2026 •

edited

Loading

LornaSIL commented Mar 12, 2026 •

edited

Loading