Repository navigation
feat(events): default the event max age to 24 hours - #424
Open
abelonogov-ld wants to merge 1 commit into
Open
abelonogov-ld wants to merge 1 commit into
abelonogov-ld wants to merge 1 commit into
Conversation
Persisted events not yet delivered are discarded after 24 hours by default, instead of 7 days. EventProcessorBuilder.maxAgeMillis still overrides it. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
EventProcessorBuilder.DEFAULT_MAX_AGE_MILLISfrom 7 days to 24 hours. Persisted events that have not been delivered within 24 hours are discarded and counted as dropped, and so is what the SDK stored for a mobile key the application stopped using. Applications can still callmaxAgeMillis(long)to keep events longer. It has no effect whereeventPersistenceisDISABLED.Stacked on #408 (tier 3).
DEFAULT_MAX_AGE_MILLISis now24L * 60 * 60 * 1000, with its Javadoc updated.EventStoreBoundsTest.keepsABatchYoungerThanTheMaximumAgeaged its batch by 6 days, which is now past the default; it ages it by 12 hours. The tests that age by 8 days still exceed the maximum age and are unchanged.iOS counterpart: launchdarkly/ios-client-sdk#549.
Tested:
:launchdarkly-android-client-sdk:testDebugUnitTest, 1257 tests, 0 failures.Note
Overview
Shortens the default retention window for persisted analytics events from 7 days to 24 hours by updating
EventProcessorBuilder.DEFAULT_MAX_AGE_MILLISand its Javadoc.When event persistence is enabled, undelivered batches older than the default max age are discarded (and counted as dropped); apps can still override via
maxAgeMillis(long). The change has no effect wheneventPersistenceisDISABLED.EventStoreBoundsTest.keepsABatchYoungerThanTheMaximumAgenow ages a batch by 12 hours instead of 6 days so it still falls under the new default.Reviewed by Cursor Bugbot for commit 057a2ef. Bugbot is set up for automated code reviews on this repo. Configure here.