Skip to content

feat(events): default the event max age to 24 hours #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abelonogov-ld wants to merge 1 commit into
base: andrey/event-durability-tier3-persistence
Choose a base branch
from
Open

feat(events): default the event max age to 24 hours #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...nt-sdk/src/main/java/com/launchdarkly/sdk/android/integrations/EventProcessorBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ public abstract class EventProcessorBuilder implements ComponentConfigurer<Event
public static final long DEFAULT_CAPACITY_BYTES = 20L * 1024 * 1024;

/**
* The default value for {@link #maxAgeMillis(long)}: 7 days.
* The default value for {@link #maxAgeMillis(long)}: 24 hours.
*/
public static final long DEFAULT_MAX_AGE_MILLIS = 7L * 24 * 60 * 60 * 1000;
public static final long DEFAULT_MAX_AGE_MILLIS = 24L * 60 * 60 * 1000;

/**
* All attributes should be treated as private
Expand Down
2 changes: 1 addition & 1 deletion ...y-android-client-sdk/src/test/java/com/launchdarkly/sdk/android/EventStoreBoundsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ public void keepsABatchYoungerThanTheMaximumAge() {
EventStore store = environmentStore(MOBILE_KEY);
stageFrames(store, 1);
store.closeBatch();
age(onlyBatchFile(store), 6);
assertTrue(onlyBatchFile(store).setLastModified(System.currentTimeMillis() - TimeUnit.HOURS.toMillis(12)));

assertEquals(0, store.discardExpired());
assertEquals(1, store.pendingBatches().size());
Expand Down
Loading