[lidge-jun]

Summary

Fixes a dev failure introduced by #8560 (#7771 slice 3, Desktop). tests/clients/desktop-cli-contracts.test.ts reads desktop/src-tauri/src/runtime_stop.rs as text and required the literal summary.message. #8560 now routes the CLI's message through StopSummary::described(), which starts with that message (self.message) and only appends the additive stop-reason notes. The contract still holds: Desktop carries the CLI's own words and never re-derives the outcome. The check now follows the new path: summary.described() is used, and described() is built from self.message, either with the notes appended or alone.

Seen in PR CI for #8564 (test 2/5, run 43056625902): the full shards run there, and test changed on #8560 could not see a test that reads Rust source as data.

Verification

• Fail-first: on current dev the file fails (8 pass, 1 fail: "the outcomes the shell can be handed are the outcomes the CLI can emit"); with this change it passes (9 pass).
• Every test file that reads the Desktop Rust sources (rg -l 'src-tauri/src|runtime_stop|exit.rs|startup.rs' tests, 17 files): 306 pass, 0 fail.

NOT RUN: full bun run test (a test-only change to one source-oracle assertion).

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed.
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-11T16:24:57.879642Z	d27d910	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[lidge-jun]

Maintainer judgment (dev-red: desktop contract test after #8560)

• Value: returns tests/clients/desktop-cli-contracts.test.ts to green on dev. feat(desktop): hand the stop deadline to ocx stop and read the Windows stop reasons (#7771 slice 3) #8560 routed the CLI message through StopSummary::described(), and the source-reading test still looked for the literal summary.message.
• UX change: none (test-only).
• Regression evidence: the new assertions are stricter than the line they replace. The reviewer's mutation checks fail whenever described() stops leading with self.message or the outcome is re-derived. All 17 test files that read the Desktop sources pass (306).
• Windows impact: none.
• Verification scope: fresh independent review APPROVE on d27d910cd7; the failing CI job on feat(service): checked Windows stop primitives and operations, unwired (#7771 slice 1) #8564 (run 43056625902, job 130647827389) is exactly this assertion.
• NOT RUN: full bun run test; PR CI was still queued at merge time.

[github-actions]

✅ Deterministic PR hygiene checks passed.