Skip to content

test(desktop): follow the stop message through described() after #8560 (dev-red) #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Nov 11, 2026
Merged

test(desktop): follow the stop message through described() after #8560 (dev-red) #8565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/clients/desktop-cli-contracts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ describe("desktop CLI contracts", () => {
// The shell does not re-derive the outcome; it carries the CLI's own words into its diagnostic.
expect(stopRs).toContain("summary.outcome");
expect(stopRs).toContain("summary.exit_code");
expect(stopRs).toContain("summary.message");
// The CLI's message reaches the diagnostic through `described()`, which starts with that
// message and only appends the additive stop-reason notes (#7771); it is never replaced.
expect(stopRs).toContain("summary.described()");
const described = stopRs.slice(stopRs.indexOf("pub fn described("), stopRs.indexOf("pub enum StopResult"));
expect(described).toContain("format!(\"{}; {notes}\", self.message)");
expect(described).toContain("None => self.message.clone()");
expect(stopRs).not.toContain('== "stopped"');
});
});
Loading