Repository navigation
Add loopback native host attach and iOS XCTest runner - #10
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit loopback attach for native test hosts and a separate public-XCTest iOS runner. Existing semantic defaults and native protocol v1 remain unchanged. LUI's Android host and DEBUG iOS read-only probe are integrated separately in logseq/lui#329; MyGo remains unsupported on its current SDK pin.
Live.connect_tcp ~host ~port/drive --tcp HOST:PORTaccepts only IPv4 loopback,localhostmapped without DNS, or IPv6 loopback, and is mutually exclusive with other CLI transports. Forwarding and host startup remain explicit; transport never implies native capabilities or semantic fallback.Native actions now share one deadline across writing, socket backpressure, framing and completion; timeout/failure poisons and closes the session. Per-call nonblocking sends preserve concurrent buffered readers. Fatal protocol errors now fail assertion/final polling too. Existing
Live.createcalls remain compatible; an optional deadline-awaresend_line_untilsupports blocking custom transports, whose callback prerequisites are documented. Close callbacks are idempotent.apple/provides a standalone UI-testing-only Xcode generator and runner. A DEBUG app exposes read-only snapshots on loopback; all input stays in a separate XCTest process, using current unique native identifiers, native text replacement and correlated snapshot/result completion. An already-running atomic XCTest call cannot be forcibly interrupted. Guides distinguish sampled settling from network/application idle and list unsupported keys/editors/scenes. Apple CI compiles the runner withbuild-for-testingwithout executing UI tests or installing an app.Validation:
dune build @all,dune runtest(22 tests), Node syntax, Xcode project generation andgit diff --checkpass. The two new boundary regressions fail before the fixes. Real-socket Unix/TCP/WS backpressure/deadline and fragmented-read probes pass; they are protocol evidence, not native UI evidence. The standalone XCTest runner passes Apple-SDK compilation. Latest browser/CDP regression recording on2aeaf98passes and replaces earlier evidence in the existing PR comment. Native Android/iOS device input remains unverified.Link to Devin session: https://app.devin.ai/sessions/9bf68438070747fb8b5c0c6718836a56
Open in Devin Desktop: https://app.devin.ai/desktop/session/9bf68438070747fb8b5c0c6718836a56?variant=devin
Requested by: @tiensonqin