Repository navigation
Add Android native Drive host and DEBUG iOS snapshot probe - #329
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in platform observation/input facilities for Drive's explicit native mode, without changing production defaults or translating native actions into LUI semantic events. Driver transport and the separate XCTest runner are in logseq/drive#10.
LuiBackend.inspect()provides copied retained nodes, incarnation guards and clipped measured geometry. The optional debug-only:driveinstrumentation host uses OSMotionEvent/KeyEventinjection and a deliberately selected test IMEInputConnectionfor Unicode/empty replacement. A standalone sample keeps runner, IME, permission and host classes out of Release; its explicit launcher preserves/restores IME selection and port forwarding. Existing Android CI compiles/tests/lints these modules.debugDriveSnapshot()andLUIDriveSnapshotProbe.startIfEnabled(...)expose read-only tree/geometry/native identifiers on IPv4 loopback only when explicitly enabled. Input remains exclusively in an external XCTest UI-testing target. Frame settings are restored on teardown; no callback is replaced.Local validation: Android full existing unit suite (71 tests), one strict v1 protocol table test, sample Debug/Release assembly, and scoped lint pass. Release manifest/dex inspection confirms no instrumentation, test IME, native host classes, INTERNET permission or debuggable flag.
git diff --checkpasses. Hosted Android checks and Apple backend/iOS compile checks passed on the initial integration; final CI includes an upstream-main refresh. The standalone XCTest runner also passes Drive's Apple compile-only gate.No native Android/iOS Drive device-input verification has been performed. Existing UIKit lifecycle regressions and compiler checks are not native-adapter evidence. Integrating apps must still hook up their DEBUG host and exercise input on a device/Simulator. The MyGo native adapter remains blocked by the current pinned SDK's lack of a public live-window input dispatcher.
Link to Devin session: https://app.devin.ai/sessions/9bf68438070747fb8b5c0c6718836a56
Open in Devin Desktop: https://app.devin.ai/desktop/session/9bf68438070747fb8b5c0c6718836a56?variant=devin
Requested by: @tiensonqin