Repository navigation
docs: explain Journal execution flows with spec types - #154
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/spec/journal_execution_flow.mli, a documentation-only walkthrough of Journal's App, Worker and Sync paths using existing spec types and API calls.app/spec/README.md.Validation
Validated the exact source tree
a4891cb1b9b382a59fa84bc8e30d2211f20cdfefwith the preparedlogseq-journal-luiswitch (OCaml 5.5.0, Dune 3.23.1):dune build @all app/native_embed.exe.o: passed.dune runtest --force: passed, including 1,339 Alcotest cases across 22 suites, 24 positive/31 negative coordination contracts, and the source-boundary check.--warn-errorand HTML generation passed.git diff --check: passed.Existing limitation
spec-dev-tool check --allstill reports six pre-existing decision-document format failures. Its output matches cleanmainbyte-for-byte; those unrelated documents are unchanged.No production behavior, dependency, Dune, packaging or GUI changes.