Repository navigation
Keep iOS journal height stable across navigation and editing - #154
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measure
LGNavigationContent's minimum scroll viewport outside keyboard and editor safe-area avoidance, and pass it throughluiMinimumScrollViewport. Today's journal keeps the same minimum height when native navigation shrinks for editing; actual content and toolbar keyboard avoidance remain unchanged.Pin SwiftPM to the merged mainline commit
cf618462from logseq/lui#333, which retains first-section height across lazy recycling without changing logical row indices. This dependency PR is already merged. The mainline commit has an identical source tree to the validated branch revision, and the iOS simulator build passes with the resolved mainline pin.Validated the pinned iOS simulator build,
dune build @shared/native/runtest, existing short/empty journal and status-bar return checks, and a temporary full-renderer probe: fresh mounts in both editing modes, navigation back, scroll return and a visible 328-point software keyboard all retain a 657-point section height.Link to Devin session: https://app.devin.ai/sessions/0bb77b567f87469f87be1e5081b16379
Open in Devin Desktop: https://app.devin.ai/desktop/session/0bb77b567f87469f87be1e5081b16379?variant=devin
Requested by: @tiensonqin
🟢 Devin Review found nothing to fix · View findings