Skip to content

Keep iOS journal height stable across navigation and editing #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiensonqin merged 2 commits into from
Nov 7, 2026
Merged

Keep iOS journal height stable across navigation and editing #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5270a
Keep iOS journal height independent of keyboard and navigation state
tiensonqin Nov 7, 2026
44aaab2
Pin LUI to merged journal height fix
tiensonqin Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apple/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apple/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ let package = Package(
.library(name: "LogseqModel", type: .dynamic, targets: ["LogseqModel"]),
],
dependencies: [
.package(url: "ssh://git@github.com/logseq/lui.git", revision: "230783b998ecd1cce3712a1d1404e44ea94915cf")
.package(url: "ssh://git@github.com/logseq/lui.git", revision: "cf618462e1c55e65a19f24a67f832137fb9fb667")
],
targets: [
.executableTarget(
Expand Down
11 changes: 11 additions & 0 deletions apple/Sources/Logseq/LGNavigationExtension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ private struct LGNavigationContent: View {
let bottomChromeIndex: Int?
let rootTransform: ((AnyView) -> AnyView)?
@State private var nativePop: LGNativeNavigationPop?
@State private var minimumScrollViewport: CGRect?
#if os(iOS)
@State private var transitions = LGNavigationTransitions()
@State private var dockedKeyboardInset: CGFloat = 0
Expand Down Expand Up @@ -758,6 +759,16 @@ private struct LGNavigationContent: View {
let _ = context.revision
let _ = search?.context.revision
navigationStack
.environment(\.luiMinimumScrollViewport, minimumScrollViewport)
.background {
GeometryReader { _ in
Color.clear
.onGeometryChange(for: CGRect.self) { $0.frame(in: .global) } action: { frame in
minimumScrollViewport = frame
}
}
.ignoresSafeArea(.all, edges: .bottom)
}
.onPreferenceChange(LUIListSurfacePreferenceKey.self) { usesSystemBackground in
usesSystemGroupedBackground = usesSystemBackground
}
Expand Down
Loading