Repository navigation
Add account deletion and privacy links in Android Settings - #158
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+879
to
+886
| list_item ~icon:(`app "open-external") ~padding:0 | ||
| ~accessibility_identifier:"link.settings.account-deletion" | ||
| ~on_press:(press send (Model.OpenExternalURL "https://logseq.com/account-deletion")) | ||
| ~text:(View_base.tr (Signal.sample model_source) "Request account deletion") []; | ||
| list_item ~icon:(`app "open-external") ~padding:0 | ||
| ~accessibility_identifier:"link.settings.privacy-policy" | ||
| ~on_press:(press send (Model.OpenExternalURL "https://logseq.com/privacy-policy")) | ||
| ~text:(View_base.tr (Signal.sample model_source) "Privacy Policy") []; |
There was a problem hiding this comment.
🔍 New settings labels remain English
With a non-English language selected, View_base.tr returns English for both new labels. Neither string exists in the dictionaries; Localization.translate falls back to the source text.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add links in Android Settings for requesting account deletion and reading the privacy policy. The deletion link opens Logseq’s public support flow, so people can request deletion in the app and from the website.
The website route is in logseq/sites#52. The Android release build is running in https://github.com/logseq/mobile/actions/runs/42838328930.