Skip to content

Add account deletion and privacy links in Android Settings #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiensonqin merged 1 commit into from
Nov 10, 2026
Merged

Add account deletion and privacy links in Android Settings #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion shared/src/logseq/view_settings.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,17 @@ let settings_kotlin_screen (context : Lui_ui.ui_context) model_source
];
];
column ~padding:16 ~background:card_bg
[ settings_account_row context model_source send ];
[
settings_account_row context model_source send;
list_item ~icon:(`app "open-external") ~padding:0
~accessibility_identifier:"link.settings.account-deletion"
~on_press:(press send (Model.OpenExternalURL "https://logseq.com/account-deletion"))
~text:(View_base.tr (Signal.sample model_source) "Request account deletion") [];
list_item ~icon:(`app "open-external") ~padding:0
~accessibility_identifier:"link.settings.privacy-policy"
~on_press:(press send (Model.OpenExternalURL "https://logseq.com/privacy-policy"))
~text:(View_base.tr (Signal.sample model_source) "Privacy Policy") [];
Comment on lines +879 to +886

@devin-ai-integration devin-ai-integration Bot Nov 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 New settings labels remain English

With a non-English language selected, View_base.tr returns English for both new labels. Neither string exists in the dictionaries; Localization.translate falls back to the source text.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

];
]

(* Native grouped-settings form: a `form`-styled content column whose
Expand Down
Loading