Skip to content

Keep runtime setup out of pending steward source checks - #8628

Merged
loopx-agent merged 1 commit into
mainfrom
codex/steward-pending-source-readiness
Nov 12, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/steward-pending-source-readiness

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Behavior

When the workspace knows the original steward binding and its Session lookup is pending, the overview can interpret the unresolved executor as a missing machine runtime. Defer the overview setup notice until the original source resolves. Keep the existing source verification and error states visible during that read.

Verification

  • Held the real bound-session HTTP lookup against the packaged Chat UI and a disposable SQLite runtime. The previous bundle showed the machine setup notice while verification was pending. This change keeps the existing verification state visible and opens the same conversation after the lookup completes.
  • The packaged reply smoke still verifies the original reply and quote, desktop and narrow layouts, keyboard access, and zero model Turns. The separate confirmed-missing runtime scenario still shows setup guidance and clears it after a re-check.
  • The exact-head Chat build, TypeScript check, five runtime-readiness tests, and standard premerge gate passed.

Visual evidence

Both arms use packaged Chat, the same synthetic Lark source, and a disposable SQLite/HTTP backend. The first viewport is captured while the original Session read is held. Base 9ce3a46bfe525aa2167de6699fc676ce8ef60247 shows the machine setup notice during verification. Head 73f58b233674a38e43fe461d319bc096ace442a9 shows the original source verification state. Releasing the read opens the same binding, Session, and reply in both arms.

Desktop before (1440 × 900) Desktop after (1440 × 900)
Desktop baseline with the setup notice during verification Desktop candidate showing original conversation verification
Narrow before (390 × 844) Narrow after (390 × 844)
Narrow baseline with the setup notice during verification Narrow candidate showing original conversation verification

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · max

本次评审对应提交 73f58b233674a38e43fe461d319bc096ace442a9。

动机 / Motivation

已经选择飞书原会话的用户打开管家总览,等待核验该会话。主干一边核验原会话,一边提示整台机器没有可用 Agent 运行环境。暂缓同一来源的 Session HTTP 请求时,主干两种宽度均出现设置卡,候选保留来源核验。来源恢复后可打开同一绑定与 Session,继续阅读原请求、答复和引用。本次覆盖总览的来源核验、失败和恢复呈现。

改动思路 / Approach

已存在的来源读回和机器目录分别提供事实,总览复用现有未解析谓词。改动限于总览传参和既有回复烟测。 Core 根据当前绑定读回原 Session。编辑区早已消费这项状态,总览现在沿用同一个判断。普通入口确认缺执行器时,继续显示缺失原因和重新检查。 原来源读取

具体改动 / Changes

关键代码讲解

  • originalSourceUnresolved 由当前 binding 存在且 Session 尚未读到派生。编辑区继续呈现核验、失败原因及重试。 来源状态 来源重试
  • PersonalWorkspacePage 在原来源读回前暂停向 ManagerHomeBoard 传入 readiness。总览仍可看目标,读回后按原状态显示运行环境。 总览调用点
  • openWhileCheckingOriginalConversation 暂缓指定 binding 的 Session GET,确认等待提示和总览后释放原 HTTP 请求,再验证原正文和引用。 打包烟测

按 docs/architecture/rfcs/app-conversation-and-async-inbox-v0.md 在 base 9ce3a46 的已接受条款验证。source_exact 对应精确绑定、Session 与正文。source_retry 对应等待、503 和同处重试。unselected_entry 对应普通入口确无执行器及重检结果。 原会话契约 运行时检查

对主干的风险 / Risks

PASS。用同一合成原来源和真实 SQLite/HTTP 对照两个打包版本。主干在 1440 和 390 px 均显示机器设置卡,候选在两种宽度保留来源核验。候选遇到 503 时显示原会话不可用及重试读取。解除故障后,从总览打开原对话,URL 的 binding、Session 和读到的正文均匹配。两臂各两条 Session,原绑定走查零 POST、零模型 Turn。

PASS。两臂在未选原会话且机器确实缺运行时的场景都显示设置,重检发现可用执行器后撤回。两臂 Chat 打包以及候选 TypeScript、五项 readiness、原回复烟测和标准 premerge canary 均通过。托管 CI 为 UNVERIFIED。

语义与 CI 对齐

沿用现有原来源与 readiness 类型,普通缺失诊断有同条件对照。 总览投影

我的整体评价 / Verdict

候选解决了原会话读取期间的设置误报,来源故障恢复后可以继续读原结果。相邻来源读取和机器目录已有各自 owner,这次无需再抽取。按 AGENTS.md 的首屏取证规则,PR 描述仍需附当前 head 的桌面和窄屏前后对照,并标明打包与合成来源。查看了 1440×900 和 390×844 px 的管家总览及恢复后原会话。窄屏来源状态和 Retry 留在编辑区旁,目标及健康提示在正文。独立验证覆盖打包 Web Chat、真实本机 HTTP/SQLite 与合成飞书来源。安装态桌面与真实飞书账号未在本轮验证。

English verdict: APPROVE. At 73f58b2, packaged browser checks reproduced the false setup notice on base, verified exact-session recovery after HTTP 503, and preserved the real missing-runtime recheck.

@loopx-agent
loopx-agent merged commit b7c9178 into main Nov 12, 2026
36 of 50 checks passed
@loopx-agent
loopx-agent deleted the codex/steward-pending-source-readiness branch November 12, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant