Skip to content

Keep runtime setup out of pending steward source checks #8628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopx-agent merged 1 commit into from
Nov 12, 2026
Merged

Keep runtime setup out of pending steward source checks #8628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion apps/presentation/dashboard/smoke/conversation-reply-browser-smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,25 @@ function next() {
if (queue.length) receive(queue.shift()); else waiting.push(receive);
});
}
async function openWhileCheckingOriginalConversation(ready, page) {
const isOriginalSource = url => url.pathname === "/api/chat/sessions"
&& url.searchParams.get("conversation_binding_id") === ready.bindingId;
const {promise: allowSourceRead, resolve: finishSourceRead} = Promise.withResolvers();
const holdOriginalSource = async route => {
await allowSourceRead;
await route.continue();
};
await page.route(isOriginalSource, holdOriginalSource);
try {
await page.goto(ready.origin + "/chat/", {waitUntil: "domcontentloaded"});
await page.getByText("正在核验原会话…", {exact: true}).waitFor({timeout: 4_000});
assert.equal(await page.getByTestId("runtime-readiness").count(), 0,
"Checking the original conversation must not show machine runtime setup");
} finally {
finishSourceRead();
await page.unrouteAll({behavior: "wait"});
}
}
async function checkReturnedFiles(ready, page, errors, writes) {
const snapshot = await (await page.request.get(`${ready.origin}/api/chat/sessions/${ready.sessionId}`)).json();
const answer = snapshot.messages.find(row => row.message_id === ready.fileMessageId);
Expand Down Expand Up @@ -113,7 +132,11 @@ try {
const snapshot = await (await page.request.get(`${ready.origin}/api/chat/sessions/${ready.sessionId}`)).json();
const source = snapshot.messages.find(row => row.role === "user" && row.turn_id);
assert.ok(source.text.startsWith("Referenced message ("), "Canonical model input stays unchanged");
await page.goto(ready.origin + "/chat/");
if (process.env.LOOPX_REPLY_BEFORE === "1") {
await page.goto(ready.origin + "/chat/");
} else {
await openWhileCheckingOriginalConversation(ready, page);
}
await page.getByRole("navigation", {name: "管家视图"}).getByRole("button", {name: /^(Chat|对话)$/}).click();
const body = "请比较这次修改，并保留原话题中的限制。Compare this change against the original constraints.";
const parent = "原要求：保留已有结果和失败记录。Original requirement: retain results and failed attempts.";
Expand Down
3 changes: 2 additions & 1 deletion apps/presentation/dashboard/src/features/personal-workspace/personal-workspace-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3016,7 +3016,8 @@ export function PersonalWorkspacePage({
<ManagerHomeBoard goals={workspaceGoals} attention={model.userTodos} onSelectAttention={openAttention}
onRetry={() => void callbacks.onRefresh?.("missing")} onRetrySource={() => void refreshWorkspace()} onSelectGoal={selectGoal} systemHealth={model.systemHealth}
onboarding={model.onboarding} onRequestGoalCreate={readOnly ? undefined : requestGoalCreate} onSuggestRequest={readOnly ? undefined : suggestReply}
runtimeReadiness={readOnly ? undefined : runtimeReadiness} recheckingRuntimes={recheckingRuntimes} onRecheckRuntimes={callbacks.onRecheckRuntimes ? recheckRuntimes : undefined}
runtimeReadiness={readOnly || originalSourceUnresolved ? undefined : runtimeReadiness}
recheckingRuntimes={recheckingRuntimes} onRecheckRuntimes={callbacks.onRecheckRuntimes ? recheckRuntimes : undefined}
operations={actionReadback.isError ? [] : homeOperations} onSelectOperation={proposal => setSelection({kind: "proposal", item: proposal})} />
) : (
<ChannelTimeline key={`${selectionScope}:${conversationKey}:${selectedAgentId}`} {...timelineReading} readOnly={readOnly}
Expand Down
Loading