[hw] Rework reset tree for non-debug-module reset#593
Draft
raylau1 wants to merge 6 commits into
Draft
Conversation
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Initial review, which I will also fix.
This commit changes existing generated main and IO resets to be sourced from lc_src, and adds a debug domain reset sourced from sys_src. Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
marnovandermaas
force-pushed
the
reset_tree_rework
branch
2 times, most recently
from
9d3cfde to
fddc761
Compare
Collaborator
|
I've added an AON domain for the IO clock and also fixed the cascade assertions that were making the block-level smoke test fail. This'll need some more testing before it can be merged. |
marnovandermaas
force-pushed
the
reset_tree_rework
branch
from
fddc761 to
5f2a7a9
Compare
It also arranges them for better readability. Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
marnovandermaas
force-pushed
the
reset_tree_rework
branch
from
5f2a7a9 to
dd5a403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a debug domain reset under the sys reset tree, and moves existing main and IO clock resets under the LC reset tree.
General improvements to reset connections are also added.
Closes #571