You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(gui): await target-switch commit before assertions - #818
The account-pool target-switch regression test can inspect the old render before React commits the requested target. Fork CI observed two reads instead of three in the in-flight-count case, and the same failure reproduced locally.
Wait for the probe's layout-effect callback before taking the post-switch observation. The old response is still released inside that layout effect, preserving the race before passive effects that the test is meant to cover. No production UI, account behavior, timeout or assertion changes.
After: bun test tests/codex-account-pool-target-switch.test.tsx in gui/: 13 pass, 0 fail, 86 assertions, Bun 1.4.4.
bun run build in gui/: passed (TypeScript and standard/classic Vite bundles).
git diff --check: passed.
Full GUI tests/lint not repeated locally due shared storage contention; current-head hosted CI passed in both repositories (upstream run 43187443405; fork run 43187437391). There is no visual change to capture. The repository-supported screenshot exemption is recorded in the upstream collaborator comment and the fork owner comment; no testing requirement is waived.
Checklist
Scope stays focused and avoids unrelated cleanup.
Docs or release notes were updated when needed (test-only change; none needed).
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (no runtime or credential changes).
No actionable comments were generated in the recent review.
Walkthrough
The target-switch regression test now waits for the new target’s layout commit before it releases the previous target’s held read and resolves the switch promise.
Changes: Target-switch regression test
Layer / File(s)
Summary
Synchronize release with layout commit gui/tests/codex-account-pool-target-switch.test.tsx
The callback now releases the previous target’s held read and resolves the switch promise during the layout phase, after the new target’s commit.
This change only adjusts test synchronization, with no production behavior change. No actionable merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "test(gui): await target-switch commit before assertions" matches the main change. The PR changes only the target-switch regression test so it waits for the new target's layout commit before…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title "test(gui): await target-switch commit before assertions" matches the main change. The PR changes only the target-switch regression test so it waits for the new target's layout commit before asserting. The title names the test scope (gui), the change (await commit), and the purpose (before assertions). It does not list files, and it is not vague.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
No GUI changes: only the target-switch test harness is changed, with no rendered component or production UI change. Verified the single-file diff at 87a04ca. Apply the repository-supported OWNER screenshot false-positive override; no CI requirement is waived. Upstream review is lidge-jun#8592. This is the isolated repair for the account-pool target-switch timing failure in #817.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The account-pool target-switch regression test can inspect the old render before React commits the requested target. Fork CI observed two reads instead of three in the in-flight-count case, and the same failure reproduced locally.
Wait for the probe's layout-effect callback before taking the post-switch observation. The old response is still released inside that layout effect, preserving the race before passive effects that the test is meant to cover. No production UI, account behavior, timeout or assertion changes.
Verification
bun test tests/codex-account-pool-target-switch.test.tsxingui/: 13 pass, 0 fail, 86 assertions, Bun 1.4.4.bun run buildingui/: passed (TypeScript and standard/classic Vite bundles).git diff --check: passed.Checklist