Skip to content

test(gui): await target-switch commit before assertions #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

test(gui): await target-switch commit before assertions #818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gui/tests/codex-account-pool-target-switch.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ async function switchTarget(targetKey: string, releasePrevious: () => void) {
configureApiTargets(relay("/same", targetKey));
actEnvironment(false);
try {
root!.render(<Probe targetKey={targetKey} onSwitch={releasePrevious} />);
// A timer scheduled before React commits can win the race on a loaded runner.
// Observe the layout commit itself; release the old read in that same phase so
// the regression still exercises the interval before passive effects run.
await new Promise<void>(resolve => {
root!.render(<Probe targetKey={targetKey} onSwitch={() => { releasePrevious(); resolve(); }} />);
});
await new Promise(resolve => setTimeout(resolve, 0));
} finally {
actEnvironment(true);
Expand Down
Loading