Repository navigation
Preserve informational flags in dashboard usage windows (VibeTV #306) - #19
marcus7989 wants to merge 1 commit into
Conversation
|
[K-Marcus] W239 self-review of The complete diff changes only Windows execution and static-CRT ZIP packaging remain pending on Paul's runner. No merge/tag/release or nesszer#306 push is authorized in this worker task. @codex review |
DreamyTalesPAN
left a comment
There was a problem hiding this comment.
Counter-review from the VibeTV team ("Paul" here = our team) at head b1174a1 (read-only, no approval).
Code check of rust/src/cli/serve/dashboard/window.rs:
isInformationalis serialized only when true (skip_serializing_if = "is_false", struct isrename_all = camelCase).make_window_with_idlecopieswindow.is_informational, so the flag comes from the engine'sRateWindowand is not guessed from "0 % and no reset".- Real zero measurements are kept:
RateWindow::new(0.0)hasis_informational: false(core/rate_window.rs:98-106), so session and weekly stay without the key but keepusedPercent: 0andresetAt: null. Your second test pins exactly this for both kinds. - Informational placeholder:
no_active_session()isinformational(..), i.e.is_informational: true(rate_window.rs:123-128, test at 262), so the first test getsisInformational: true,usedPercent: 0,resetAt: null. unavailable: window.is_informationalandidleare unchanged, so existing clients see the same payload except for the additive key. TheWindowPayloadliteral is built in one place only, so the new field is not missing elsewhere.
Nothing blocking. One style remark: the new mod tests sits between the is_false helper and make_window_with_idle; it is conventional to put it at the end of the file. Native Windows validation and the .16 packaging are still open, as you wrote; I did not run anything.
|
[K-Marcus] W291 built an artifact-only CI candidate from exact Win-CodexBar #19 CI 40891208141: native static-CRT CLI build, PE/CUI/version audit and upload succeeded. Artifact Dashboard 50/50. Full native library suite (serial) 2037 passed / 1 failed / 1 ignored; run correctly stays red. Both old PTY/login tests passed. New failure: W235 native customer-flow checklist and exact nesszer#306 installer (9999.0.494, Platform CI 40868740907) are in the local handoff |
|
[K-Marcus] W307 verified unchanged #19 head |
Dashboard account snapshots must distinguish an informational placeholder from a measured 0% window without a reset. Preserve
RateWindow.is_informationalas the additive schema-v1 keyisInformational; omit the key when false. This lets the VibeTV account adapter retain real zero measurements while excluding explicit informational windows (VibeTV-shop/vibetv#306).Based on current
vibetv/v0.60.3-vibetv.15(935b98b118f1599c191ccf2754a6f352d806ffac), including #15–#17. The existingunavailableandidlepayload fields are preserved. Two source tests cover an informational session and measured session/weekly zeroes without resets.Validation on macOS (native aarch64 only):
cargo fmt --all -- --checkandgit diff --check: pass.cargo test -p codexbar --lib --locked --target aarch64-apple-darwin cli::serve::dashboard: 50 passed..15baseline reproduces the same four failures (1995 passed, 4 failed, 1 ignored):config_dir_must_stay_within_home,windows_shims_and_paths_are_normalized_for_dialect,normalizes_codex_root_to_sessions_dir, andconfig_matching_respects_enabled_flag.Native Windows validation and packaging remain required on Paul's runner. Build the exact PR head with static CRT, then prepare
CodexBarCLI-v0.60.3-vibetv.16-windows-x64.zipcontainingcodexbar-cli.exeplus its.zip.sha256sidecar, matching.13packaging. Merge, tag and prerelease publication are reserved for the orchestrator after Windows validation; this PR does not change the VibeTV package pin.