Repository navigation
[K-Marcus] Normalize Desktop restart test fixture paths - #21
marcus7989 wants to merge 3 commits into
Conversation
DreamyTalesPAN
left a comment
There was a problem hiding this comment.
Counter-review of #21 at head 7b8a834deab1eac699e4e90784be68d286ba2996 (read-only review, nothing built or pushed on my side).
Verdict: correct and minimal for the code change. No blocker. One non-blocking request on the workflow file.
- Product code untouched. In
rust/src/codex_accounts/codex_desktop.rsthe#[cfg(test)]module starts at line 314; both hunks (@@ -347and@@ -389) are below it. The only other file is a new workflow. - Fix is correct. The restart script already resolves the package root with
[System.IO.Path]::GetFullPath(...)(lines 155/158), so the mockGet-AppxPackageand the expected launcher must use the same spelling. ApplyingGetFullPathto$fixturePackagein the fixture mirrors the product behavior. It does not mask a product bug: the product keeps its normalization and the test now matches it. - No assertion weakened. Stop/launch, standalone-CLI safety (
987654320not stopped,/Trejected), session backup/clear andunrelated-fileassertions are all unchanged. The only other change adds exit code, stdout, stderr and the fixture log to the failure message, which is diagnostic only. - CI evidence checked. Run 40896491998 (
desktop, SUCCESS) is on exactly this head. Theguardjob shows SKIPPED because the PR is a draft. - Non-blocking:
.github/workflows/codex-desktop-test.yml(+101 lines) is a one-off proof harness. It pins four historical SHAs and triggers only on pushes tocodex/w296-desktop-restart-test. Once merged intovibetvit can never fire again and is dead weight. Since you plan to merge #21 intovibetv, please drop the workflow file from the merge (or from this PR) so only the 8-linecodex_desktop.rschange lands. The red-to-green proof stays in run 40896491998.
Not checked: a real-Windows run on my side; I relied on the linked GitHub-hosted run.
|
[K-Marcus] @codex review W307 applied Paul's counter-review at https://github.com/VibeTV-shop/vibetv/issues/284#issuecomment-6501070522. Exact new head The old native red/green proof remains at run 40896491998. A separate temporary CI branch will test this exact source and the cumulative #21 → #20 → #19 → #18 source without carrying an ephemeral workflow in this PR. New-run evidence will follow; no new CI success or merge approval claimed yet. Format and whitespace checks passed. No device action. |
|
[K-Marcus] W307 native CI finished GREEN at exact source |
[K-Marcus] The Windows Codex Desktop restart test used a short
RUNNER~1path while the restart script normalizes it to the longrunneradminform. Its fake process/launcher therefore failed withWrong launchereven on the unchanged base.This PR normalizes the fixture package path identically and includes the existing fixture log, stdout/stderr and exit status in a failure. It changes only
rust/src/codex_accounts/codex_desktop.rs; production code and all safety/session assertions remain unchanged. The one-off workflow was removed after Paul's counter-review.Validation at exact head
c8e11559ed78df845a1ee732e511025b458d1320:Review: Paul's old-head counter-review had no blocker; his workflow removal request is fixed. Automated Codex review requested on the new head, still pending. Keep Draft; no merge approval. Planned order #21 → #20 → #19 → #18. No devices, release or .16 pin change.
Additional repository-required native Desktop-shell unit suite on unchanged cumulative source
ef4aace55a59ed61fc66ab9b7d341129b82afa69: run 40908176267, 431 passed / 0 failed / 0 ignored / 0 filtered. Combined backend, CLI and Desktop-shell total: 2,481 PASS / 0 FAIL / 1 pre-existing ignored, same exact cumulative source. Both Rust manifests are verified; no app/device/customer-flow test is claimed.The current-head Codex request has now had at least 20 minutes without a bot review, inline finding or bot reaction. Review remains pending; no automated no-findings or merge readiness is claimed.