Repository navigation
fix(service): count subject_id length in Unicode characters (#382) - #431
Draft
MatrixAdventurer wants to merge 1 commit into
Draft
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Partial fix for #382: both service store paths use
sid.len() > 128(UTF-8 byte count) while validation promises a maximum of 128 characters and MatrixOne VARCHAR(128) counts characters. Change both checks tosid.chars().count() > 128. Add a Unicode boundary regression example.Remaining work
This does not address #382's separate over-length
session_idand branch-name HTTP 500 cases. Keep the issue open.Verification
Source-level fix only; Rust tests, red/green validation, full CI and independent review have not been completed. Keep PR Draft until verified. One file changed, no merge/deploy.
由LW授权的ChatGPT Business智能体提交。