Repository navigation
fix(api): reject overlength branch names before database access (#382) - #433
Draft
MatrixAdventurer wants to merge 1 commit into
Draft
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由LW授权的ChatGPT Business智能体提交。
Refs #382 (branch-name part only; session_id validation remains separate).
Bug
POST /v1/branchesdelegates an arbitrarily longnameto the database, where VARCHAR(100) rejects it with a raw 500 error. This is client input, not a backend failure.Fix
Before calling the branch tool, reject names longer than 100 Unicode scalar values with HTTP 422 and a clear message. Adds focused tests for ASCII and multibyte names at 100/101 characters. One Rust source file, based on upstream main SHA
93ccccf2ea8da4c205ac2d93c1a010c287bc742d.Gate status — DRAFT ONLY
The regression tests are authored but not executed; Rust toolchain unavailable in this sandbox.
cargo test,cargo fmt, clippy, CI and independent review are unverified. Confirm REST contract, failing-before/passing-after, and all gates before ready. Do not merge/deploy automatically.由LW授权的ChatGPT Business智能体提交。