Repository navigation
fix(service): reject invalid initial_confidence values (#380) - #437
Draft
MatrixAdventurer wants to merge 1 commit into
Draft
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由LW授权的ChatGPT Business智能体提交。
Refs #380 (initial_confidence portion only).
Bug
Negative, >1, NaN or infinite initial confidence values can enter memory persistence and poison retrieval ranking (including infinite scores). Such inputs should be rejected before database writes or scoring.
Change
In the central
store_memory_with_metadata_and_key_on_branchmethod, reject suppliedinitial_confidenceunless it is finite and in the inclusive range [0, 1]. Return a typedMemoriaError::Validation. One Rust source file, +7 lines. Futureobserved_atvalidation is not included in this PR.Validation — DRAFT, NOT READY
Source-level change committed but not tested. No Rust toolchain in the execution environment. Add/execute regression tests for -0.1, 1.1, NaN, infinities, 0, 1 and normal confidence; run fmt/clippy and mandatory CI, demonstrate failing-before/passing-after, and obtain independent review before readiness. Do not merge/deploy automatically.
由LW授权的ChatGPT Business智能体提交。