Skip to content

fix: restore signed-in playback and complete Chinese localization - #2891

Open
LuoH-AN wants to merge 4 commits into
maxrave-dev:devfrom
LuoH-AN:fix/chinese-translations
Open

LuoH-AN wants to merge 4 commits into
maxrave-dev:devfrom
LuoH-AN:fix/chinese-translations

Conversation

@LuoH-AN

@LuoH-AN LuoH-AN commented Nov 15, 2026 •

Copy link
Copy Markdown

What & why

Chinese users see English labels across recently added features because the Simplified Chinese resource file lacks 566 entries and Traditional Chinese lacks 209. Complete those missing entries, preserve format arguments and Chinese plural rules, and localize the remaining hardcoded sleep-timer options, blog notification label, chart entry and lyric vote labels. Both Chinese locales now cover all 1,144 current resources. Existing Traditional Chinese translations are reused for Simplified Chinese where appropriate; new translations also correct terminology such as musical key and scale.

Update the core submodule to the reporter-tested signed-in TV playback fixes in maxrave-dev/core#60. The fork Release APK contains both that playback change and this localization update. The playback implementation should be reviewed and merged in the core PR first.

Submitted for maintainer review. The project's translation process uses Crowdin; these resource changes need maintainer direction for import, and human line-by-line review has not been confirmed. No personal-review checkbox is asserted.

Validation: both XML files parse, resource names are unique, all base resource names are covered, and format arguments and plural other forms were checked. Android Full Release built successfully in GitHub Actions; APK signature, package name, and non-debuggable status passed CI checks. Both packaged Chinese resource sets were verified to contain all 1,144 resource names. The issue reporter installed the Release APK on Android, checked the Chinese UI, and confirmed that the localization is satisfactory. This confirms the on-device UI check; it does not assert line-by-line source review.

The updated core pin also includes follow-up playback recovery: extract audio without requiring a TV title, try alternate audio renditions after a definitive rejection, and preserve the saved login in Brave fallback requests. These changes address errors found in the reporter's subsequent Release log and are included in the Release r4 build. The reporter's Chinese UI approval applies to r3; playback recovery in r4 still needs on-device validation.

Linked issue

Related playback report: #2889. Core implementation: maxrave-dev/core#60.

Translation acceptance is pending; no accepted Chinese-localization issue is claimed.

Checklist

  • This PR addresses an accepted issue (linked above)
  • I wrote or personally reviewed every line of this change
  • I tested it on Android and/or Desktop (Android: the issue reporter checked the Chinese UI in the Release APK and confirmed the result.)

Release r4 built successfully in GitHub Actions. CI verified the retained APK signature, package name and non-debuggable status; the downloaded APK passed ZIP integrity checks. Both packaged Chinese resource assets are byte-for-byte identical to the reporter-approved r3. The final core pin includes the audio-quality fallback fix as well. The new playback recovery still needs on-device validation with the previously failing tracks.

@github-actions

Copy link
Copy Markdown

Thanks for the PR! Please complete the pull request template — in particular the checkbox confirming you wrote or personally reviewed every line, and the issue this change addresses. It helps us tell real contributions from the flood of auto-generated ones. Edit your PR description; no need to open a new PR.

@github-actions github-actions Bot added the needs-template PR template incomplete — see the triage comment label Nov 15, 2026
@LuoH-AN
LuoH-AN marked this pull request as ready for review November 15, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-template PR template incomplete — see the triage comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant