Repository navigation
Conversation
|
Thanks for the PR! Please complete the pull request template — in particular the checkbox confirming you wrote or personally reviewed every line, and the issue this change addresses. It helps us tell real contributions from the flood of auto-generated ones. Edit your PR description; no need to open a new PR. |
LuoH-AN
marked this pull request as ready for review
November 15, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Chinese users see English labels across recently added features because the Simplified Chinese resource file lacks 566 entries and Traditional Chinese lacks 209. Complete those missing entries, preserve format arguments and Chinese plural rules, and localize the remaining hardcoded sleep-timer options, blog notification label, chart entry and lyric vote labels. Both Chinese locales now cover all 1,144 current resources. Existing Traditional Chinese translations are reused for Simplified Chinese where appropriate; new translations also correct terminology such as musical key and scale.
Update the
coresubmodule to the reporter-tested signed-in TV playback fixes in maxrave-dev/core#60. The fork Release APK contains both that playback change and this localization update. The playback implementation should be reviewed and merged in the core PR first.Submitted for maintainer review. The project's translation process uses Crowdin; these resource changes need maintainer direction for import, and human line-by-line review has not been confirmed. No personal-review checkbox is asserted.
Validation: both XML files parse, resource names are unique, all base resource names are covered, and format arguments and plural
otherforms were checked. Android Full Release built successfully in GitHub Actions; APK signature, package name, and non-debuggable status passed CI checks. Both packaged Chinese resource sets were verified to contain all 1,144 resource names. The issue reporter installed the Release APK on Android, checked the Chinese UI, and confirmed that the localization is satisfactory. This confirms the on-device UI check; it does not assert line-by-line source review.The updated core pin also includes follow-up playback recovery: extract audio without requiring a TV title, try alternate audio renditions after a definitive rejection, and preserve the saved login in Brave fallback requests. These changes address errors found in the reporter's subsequent Release log and are included in the Release r4 build. The reporter's Chinese UI approval applies to r3; playback recovery in r4 still needs on-device validation.
Linked issue
Related playback report: #2889. Core implementation: maxrave-dev/core#60.
Translation acceptance is pending; no accepted Chinese-localization issue is claimed.
Checklist
Release r4 built successfully in GitHub Actions. CI verified the retained APK signature, package name and non-debuggable status; the downloaded APK passed ZIP integrity checks. Both packaged Chinese resource assets are byte-for-byte identical to the reporter-approved r3. The final core pin includes the audio-quality fallback fix as well. The new playback recovery still needs on-device validation with the previously failing tracks.