Repository navigation
Conversation
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-in SimpMusic users on a VPN exit challenged by YouTube can fail to play tracks: anonymous extraction is rejected with
LOGIN_REQUIRED, and later attempts can obtain audio URLs that return HTTP 403. The app reports these failures asERROR_CODE_IO_UNSPECIFIED.Use PipePipe's authenticated
tv_samsungclient when a login cookie is present, restoringvisionoson logout. PipePipe scans the supplementaryWEB_REMIXresponse before the configured player's streams and keeps the first similar format; restrict that supplementary response to Premium audio itags 141/774 so ordinary web formats cannot replace the TV audio URLs.Accept audio-only extraction results and validate a standard audio stream with a one-byte range GET instead of randomly checking audio or video URLs. Remove the second random HEAD check after mapping the streams. Preserve decoder fallback for definitive URL rejection, while allowing the player to attempt playback after an inconclusive network check. Raise PipePipe's five-second extraction deadline and downloader timeouts to 30 seconds for slower routes. Add diagnostics without logging full media URLs or cookies.
Follow-up recovery from the reporter's latest Release log: PipePipe can stop at
Could not get namebefore extracting audio, and a single TV audio rendition can return HTTP 403 while Brave falls back anonymously and receivesLOGIN_REQUIRED. Fetch audio streams directly without requiring StreamInfo metadata (the app already has metadata from its WEB_REMIX response). If an audio rendition is definitively rejected, try the remaining supported audio renditions before changing decoder tiers; when recovering this way, retain only the accepted audio rendition so downstream format selection cannot pick a rejected or unverified alternative. Preserve Brave fallback login using the saved cookie and origin-bound SAPISIDHASH, restricted to the exact HTTPS YouTube hosts even across redirects. Set Brave connection/read timeouts to 30 seconds as well.When the preferred Premium format and its codec twin are both absent, select available audio before the generic format fallback; this prevents a recovered lower-quality audio stream from being replaced by a video-only URL.
Related reports: maxrave-dev/SimpMusic#2889 and maxrave-dev/SimpMusic#2861.
Validation:
After merging, SimpMusic needs to update its
coresubmodule pin to include these commits.Companion app PR: maxrave-dev/SimpMusic#2891 updates the core pin and completes Chinese localization in the app repository. Translation-process acceptance and human source review remain pending; the localization files are outside this core repository.
The companion Android Full Release APK with Chinese localization also built successfully in GitHub Actions, using the same core commit as this PR.
Release r4 built successfully in GitHub Actions, including the final audio-quality fallback change. CI verified the retained APK signature, package name and non-debuggable status. The downloaded APK passed ZIP integrity checks, and both packaged Chinese resource assets match the reporter-approved r3 exactly. The new playback changes still need on-device validation with the previously failing tracks. The original log and login credentials are not attached to this PR.