fix(fabric): fix Text overflow in ScrollView on first render (macOS)#2880
Open
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(fabric): fix Text overflow in ScrollView on first render (macOS)#2880Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
On macOS, the _containerView (NSScrollView's documentView) has autoresizingMask set so it fills the visible area before React's first layout pass. However, AppKit's autoresizing corrupts the documentView's frame by adding the NSClipView's size delta to the container's dimensions (e.g., during initial tile or window attachment), inflating it well beyond the correct content size and producing massive horizontal and vertical overflow on first render. The fix adds a layoutSubviews override on macOS that resets the documentView frame to the correct React-managed content size after AppKit's layout pass (which triggers autoresizing). This corrects the corruption while preserving the autoresizingMask needed for the documentView to fill the visible area before React's first updateState. Fixes microsoft#2857 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Saadnajmi
force-pushed
the
fix-scrollview-text-overflow-first-render
branch
from
731e9fe to
f3650be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layoutSubviewsoverride inRCTScrollViewComponentViewon macOS that resets the_containerView(documentView) frame to_contentSizeafter AppKit's autoresizing corrupts itRoot Cause
On macOS, the
_containerViewserves as theNSScrollView'sdocumentView, whose frame directly determines the scrollable content area (unlike iOS whereUIScrollView.contentSizeis a separate property).React's layout system explicitly manages
_containerView.frameviaupdateState:to match the content bounding rect. However,autoresizingMaskcaused AppKit to also resize the container whenever theNSClipViewresized (e.g., during initialtileafter mounting). This added the clip view's size delta to the container's dimensions, inflating it well beyond the correct content size.The
layoutSubviewsoverride runs after AppKit's layout pass (which triggers autoresizing), so it reliably corrects the frame back to the React-managed_contentSize.The issue self-corrects on window resize because the size change triggers a React re-layout that overwrites the corrupted frame with fresh measurements.
Test plan
Fixes #2857
🤖 Generated with Claude Code