Skip to content

fix(fabric): fix Text overflow in ScrollView on first render (macOS) #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saadnajmi merged 1 commit into from
Apr 2, 2026
Merged

fix(fabric): fix Text overflow in ScrollView on first render (macOS) #2880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,30 @@ - (void)dealloc
#endif // [macOS]
}

#if TARGET_OS_OSX // [macOS
- (void)layoutSubviews
{
[super layoutSubviews];

// On macOS, the _containerView is the NSScrollView's documentView and has autoresizingMask set so
// it fills the visible area before React's first layout pass. However, AppKit's autoresizing can
// corrupt the documentView's frame by adding the NSClipView's size delta to the container's
// dimensions (e.g., during initial tile or window resize), inflating it well beyond the correct
// content size. This produces massive horizontal and vertical overflow on first render.
//
// After React has set the content size via updateState:, we reset the documentView frame here to
// undo any autoresizing corruption. This runs after AppKit's layout (which triggers autoresizing),
// so it reliably corrects the frame.
if (!CGSizeEqualToSize(_contentSize, CGSizeZero)) {
CGRect containerFrame = _containerView.frame;
if (!CGSizeEqualToSize(containerFrame.size, _contentSize)) {
containerFrame.size = _contentSize;
_containerView.frame = containerFrame;
}
}
}
#endif // macOS]

#if TARGET_OS_IOS
- (void)_registerKeyboardListener
{
Expand Down
Loading