Repository navigation
fix(author): the skill follows the owner's flow, and every content type's file names the source's own fields - #183
Merged
Conversation
… and the skill asks for the author up front A chat that read a type file copied its example, `type` and `params` alone, and left out the author, which the build refuses and only the user can give (the owner's ChatGPT run on 0.9.1). Each content type's generated Fields section now says a source names its own title, language, license and authors beside params (SOURCE_FIELDS, written by schemaMarkdown for content types, not parts), SKILL.md's step 1 asks for the author's name and the licence before the source is written, step 2 names the four, and the brief says never to make a name up. On Haiku, with no author named: 0.9.1's text asked in 2 of 3 runs and the third wrote "Quiz author"; this text asked in 3 of 3. Closes #182
Contributor
There was a problem hiding this comment.
1 issue found across 33 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/h5p-author/references/types/H5P.TrueFalse.md">
<violation number="1" location="skills/h5p-author/references/types/H5P.TrueFalse.md:29">
P2: The JSON example above omits all four fields this sentence says the build requires, so copying it into `h5p-author build` fails validation. Add `title`, `language`, `license`, and `authors` to the example.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
|
||
| ## Fields of H5P.TrueFalse 1.8 | ||
|
|
||
| A source names its own `title`, `language`, `license` and `authors` beside `type` and `params`, which holds the fields below: the build refuses one without any of them. The author's name is the user's to give: ask for it when they have not. |
Contributor
There was a problem hiding this comment.
P2: The JSON example above omits all four fields this sentence says the build requires, so copying it into h5p-author build fails validation. Add title, language, license, and authors to the example.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At skills/h5p-author/references/types/H5P.TrueFalse.md, line 29:
<comment>The JSON example above omits all four fields this sentence says the build requires, so copying it into `h5p-author build` fails validation. Add `title`, `language`, `license`, and `authors` to the example.</comment>
<file context>
@@ -26,6 +26,8 @@ One statement the learner marks true or false.
## Fields of H5P.TrueFalse 1.8
+A source names its own `title`, `language`, `license` and `authors` beside `type` and `params`, which holds the fields below: the build refuses one without any of them. The author's name is the user's to give: ask for it when they have not.
+
- `media` group — Media
</file context>
…s alone cubic's review: "the build refuses one without any of them" read as refusing only a source missing all four, and the examples above the line looked like whole sources. The line now says all four are required, a source missing any of them refused, and that the example is `type` and `params` alone. The example is labelled rather than given the four: a name written in it would be copied as the author and build, where the model is to ask.
…d licence or a skip, then the source, then the best build The owner's flow (#184): the content type, chosen with the user; then the author and licence, asked once the type is chosen, which the user fills or skips, a skip taking the name the model knows them by, or "Unknown", and U; then the source; then the build the environment allows best, said to the user. SKILL.md writes the order out before step 1; step 1 proposes the type unless the user named one from the table ("a quiz" names none) and asks for the author on its own after the choice; step 3 opens with the three ways to build. The brief and every content type's file (SOURCE_FIELDS) carry the skip. On Haiku, with a quiz asked for and nothing named: until step 1 said "a quiz" names no type, 4 of 6 runs chose the type themselves; since, 4 of 4 asked the type, then the author, and wrote the given name or "Unknown" and U. Closes #184
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 33 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…d for, and what the user gave stays cubic's review of #183: the skip was written for the author and the licence at once ("a skip takes the name you know them by, or "Unknown", and the licence U"), so a user who gives a name and skips the licence could have the name replaced, and step 1 asked for both again when one was given. SKILL.md's step 1, the brief and SOURCE_FIELDS (so the 28 content types' files) now ask only for what the user has not given, say what they gave stays, and give each skipped value its own default: the name the model knows them by, or "Unknown"; the licence U. Haiku, in the chat stand-in: the old text did not go wrong in three runs (a name and no licence, a licence and no name, the author named in the request and the licence skipped). The new text, five of five (those three, both skipped, both given): what was given is written, the default for what was skipped, and with the author named in the request only the licence is asked for. All eight packages pass h5p-verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182. Closes #184.
The owner's ChatGPT run on 0.9.1, given the skill's link, wrote a quiz's source without
authors, which the build refuses (#182). Every content type refuses a source withouttitle,language,licenseorauthors(checked by building each of the 28 the skill lists withparamsalone). But every type file's example istypeandparamsonly, and since #181 a chat reads the type file and copies it. The types' own required fields were never the gap: each type file's generated Fields section marks them.The owner then set the flow the skill follows (#184): the content type, chosen with the user; then the author and licence, which the user fills or skips (a known name or a default); then the source; then the best way to build it for the situation, in the app or by a link to the build page.
What changes
U(undisclosed). Never a name made up for them. That each value's skip is its own was cubic's second review, bf9d0be.SOURCE_FIELDS, written byschemaMarkdownfor content types and not parts: "The example istypeandparamsalone, andparamsholds the fields below. A source also names its owntitle,language,licenseandauthors, all four required: the build refuses a source that leaves out any of them. The author's name and the licence are the user's: ask for what they have not given. For a name they skip, write the one you know them by, or "Unknown"; for a licence they skip,U." The example is labelled rather than given the four fields: a name written in it would be copied as the author and build. That was cubic's review, 31d0989.sync:skillwrote the line into the 28 content types' files; Image, Text, AdvancedText and Video are unchanged. A chat with no skill at all gets it too, in the type file the build page hands over.design/author.mdsays why, and what was measured.Tested
pnpm --filter @missing-elements/h5p-author test:unitpasses, 179 tests, and so does the typecheck. The new test fails when the line goes into a part's file too (tried).pnpm --filter @missing-elements/h5p-skills testpasses, 77 tests: every type file is current with the generator, and every example builds and plays.U. Every package passes h5p-verify.<p>tags into Question Set's overall feedback, a plain-text field. The build noted it, and the run rebuilt once.To release
h5p-author 0.9.2, a patch: the skill's text and the type files' generated section.
schema --markdownprints the new line for a content type. Then the site's pin moves to it, for/h5p/skill/and the build page's type files. Installed copies neednpx skills update -gand a new upload to the Claude app.