Repository navigation
Conversation
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR forwards the stream notifier's write RPCs to the active cluster, and adds the notifier tests for failover, owner checks and failed closes.
AttachStreamCallback,DetachStreamCallbackandNotifyStreamjoin the selected-APIs forwarding list.DescribeStreamNotifierstays local.TestStreamNotifierForwardingSuitechecks forwarding from a standby cluster and that an attached callback survives a namespace failover.It carries the forwarding half of moetemp/temporal#42. The System Nexus operations and their test stay in Bridge.
Why?
The notifier is an execution in the namespace, so its writes must reach the active cluster (DD-50).
How did you test it?
Link to a test plan if any -
common/rpc/interceptorunit tests, the xdcTestStreamNotifierForwardingSuite, and the functionalTestStreamNotifier*tests on both caller kinds.