Repository navigation
Bug 2091196 - fetch_product_versions is not cached for the request: buglist.cgi makes 42 memcached lookups, and a new HTTP request on every call when the product-details endpoint fails - #2823
Merged
Conversation
…uglist.cgi makes 42 memcached lookups, and a new HTTP request on every call when the product-details endpoint fails
There was a problem hiding this comment.
🟡 Changes recommended
The empty import list suppresses MockLocalconfig::import, leaving LOCALCONFIG_ENV unset and causing the test to fail before its first assertion in checkouts without site configuration or an externally set environment variable.
1 open issue
What changed in this PR
This PR reduces repeated cache and HTTP lookups when rendering Bugzilla pages by reusing product-version results and field metadata within each request.
Changes:
- Cache product-version results per request, including failures and memcached hits.
- Reuse request-cached fields when checking field visibility.
- Add tests for successful fetches, failures, separate products, and missing endpoint configuration.
| File | Description |
|---|---|
t/util-fetch-product-versions.t |
Adds regression tests for request-level product-version caching. |
extensions/BMO/Extension.pm |
Prefers cached field metadata over repeated memcached lookups. |
Bugzilla/Util.pm |
Retains product-version results, including failures, for the current request. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
cgsheeh
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.