Repository navigation
feat(desktop): add Runtime state observations - #2474
Merged
Merged
Conversation
knqiufan
requested review from
AlexStocks,
PsiACE and
frostming
as code owners
November 4, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Refs #2105 (03-A / 03-B), #2100, and RFC #1455. Keep #2105 open for installed Windows/macOS acceptance and coordination with #2361.
Rationale for this change
The Runtime state tab had no view of the selected Server or the local service. A liveness response, a processing outcome, and an OS service state answer different questions; users need to see each independently.
What changes are included in this PR?
Are there any user-facing changes?
Observation → Runtime state is now usable. There are no changes to HTTP contracts, profile storage or the Server qualification catalog. This PR stands on master after #2220; #2361 still owns separating readiness from Connections and anonymous business revalidation. After integration, share its final identity/readiness boundary and qualify the combined product client. Signed package, installed accessibility/scaling, and platform service acceptance remain separate.
How was this change tested?
pnpm typecheck,pnpm test(187 passed),pnpm lint,pnpm build. Mocked IPC covers independent loading, denial, keyboard cancellation, and stale Server/local results.cargo test --locked(135 passed, three opt-in tests); Clippy all targets with warnings denied, format and IPC export drift checks passed. Two opt-in tests were also run explicitly against a registered real CLI and a real read-only Ops subprocess. The independently bundled helper test still requires an external bundle.desktop/tests/real_server.py --product-qualification sqlite-stats-63e9665c-v1: all four built-wheel SQLite modes passed through the ordinary native manager (anonymous loopback, Bearer, HTTPS with custom CA and base path, and enforced Access provider). The recorded wheel matched its qualification SHA-256. This is real Server/API and native protocol evidence, not installed-package acceptance.AI usage statement
OpenAI Codex (GPT-6) assisted with implementation, Open Code Review delegation, regression tests, real-Server execution, and documentation.