Repository navigation
refactor(imports)!: retire historical reader formats and Cloud checkpoints - #2602
Conversation
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for simplifying the scanner import path. This owner-level merge-safety review found no material issues across all 56 changed files. Current selection/destination binding and receipt-based retries remain intact. The intentional compatibility break is documented: finish pending submissions with the client that created them before upgrading.
On the latest head, SDK build/type checking, changed-file formatting and 380 publication tests passed; one Windows-only case was skipped. Another 743 reader/payload tests passed before the two-file cleanup, which leaves those inputs unchanged. No live Cloud service was used.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Scanner readers and Cloud publication use the current capture and checkpoint formats. This removes the code that inferred historical request identities during retries.
Review in order: #2602 → #2603 → #2604.
Changes
Testing
Built the SDK, bundled plugin and CI tools. SDK and MCP type checks, the plugin source compatibility check and its nine tests passed.
On rebased code, 470 scanner tests and 380 Cloud transport tests passed, including the physical-parent path regression. One Windows-only permission test was skipped on Linux. Formatting and Markdown checks also passed.
Ran Trivy, Semgrep (JSON and SARIF), and OpenGrep on pinned public source checkouts. Across these inputs 216 eligible records imported, all 216 retained their IDs and versions on replay, and 19 ambiguous Trivy observations were excluded.
Loaded published scanner reports for Snyk, Wiz, Black Duck, Checkmarx, Endor and Veracode. The checkpoint cleanup also passed 65 targeted retry tests, with one Windows-only skip on Linux.
Risk and rollout
This is a breaking reader and checkpoint change. Finish interrupted submissions with the client that created them. If the outcome is uncertain, inspect the inbox job or repository records before approving a fresh submission. Recollect archived Semgrep Platform v1 and Snyk REST v1 captures with the current collector. The command names and arguments stay the same.
Public disclosure review