Repository navigation
feat(plugin): guide Codex through scanner imports and workbench publication - #2604
Conversation
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for the clear acquisition-to-workbench workflow. This owner-level merge-safety review found no material issues in the stacked diff. The skill reuses the readers and SDK, retains exact selections and explicit Cloud upload approval, and documents retries against the approved finding versions.
Verified 40 CLI help tests, 13 routing-harness tests, nine portable compatibility tests, Ruff, focused formatting, TypeScript checking, SDK/plugin builds, and both compiled help entrypoints. The documented offline walkthrough also passed with real SQLite: two imports, the exact selected Guardian string ID, and zero publications. Live scanner/MCP acquisition and Cloud upload were not exercised.
98bb6e2 to
c50d6f5
Compare
5ea50c3 to
4022a78
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for clarifying the stored-publication calls and partial-import handling. This owner-level merge-safety re-review found no material issues in the updated ten-file stacked diff. The skill’s SDK calls, approval steps and partial-import exit status match the implementation.
On this head, 40 CLI help tests, 13 routing-harness tests, nine portable compatibility tests, SDK/plugin builds, type checking, Ruff and both compiled help entrypoints passed. The documented offline walkthrough also passed with real SQLite: two imports, the exact selected Guardian string ID, and zero publications. Live scanner/MCP acquisition and Cloud upload were not exercised.
c50d6f5 to
b9540f4
Compare
4022a78 to
b343baa
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
b343baa to
ec6c591
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks—this owner-level merge-safety re-review of ec6c5912 found no material issues in the ten-file stacked diff. The guidance matches the current SDK’s local import, exact version selection, approval and retry behavior.
Fresh verification passed 100 CLI/import tests, 13 routing-harness tests, nine portable compatibility tests, SDK/plugin builds, type checks and formatting. Both compiled help entrypoints and the documented offline walkthrough passed; real SQLite contained two imports, the exact selected Guardian string ID and zero publications. Live scanner/MCP acquisition, Cloud upload and model routing were not exercised.
ec6c591 to
e86764f
Compare
e86764f to
1f710a3
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for updating the scanner-import and workbench guidance. Owner-level merge-safety re-review of 1f710a3: no material findings in the ten-file diff. The acquisition guidance and updated collector examples match the current SDK and CLI. Publication uses stored finding versions, explicit preview approval, and existing receipt/retry handling.
Fresh verification passed 107 CLI/import tests, 13 routing-harness tests, nine portable compatibility tests, SDK/plugin builds, type checks, Ruff and formatting. Both compiled help entrypoints and the documented offline walkthrough passed; real SQLite contained two imports, the exact selected Guardian ID and zero publications. Live scanner/MCP acquisition, Cloud upload and model routing were not exercised.
Summary
Codex can use a scanner executable, a hosted collector, a connected MCP tool, or a saved report to fulfill an import request. A later request to publish starts with the findings already in the workbench.
Review in order: #2602 → #2603 → #2604.
Changes
Testing
All 40 CLI help tests and 13 routing-harness tests passed after rebasing. Both compiled help entrypoints displayed the new guidance.
Ran the documented offline example with the built SDK, bundled plugin and real SQLite. It stored one Trivy finding and one Guardian finding, kept the exact selected Guardian ID, and recorded two imports and zero publications.
Exercised fresh Trivy, Semgrep and OpenGrep scans plus GitHub and SonarCloud API data. A parser written for a public advisory API imported five records with the installed SDK, preserved the original evidence on replay and rejected a stale selection after an upstream revision changed.
The native model-routing evaluation stopped before a model turn with HTTP 401. The routing checks above exercise the deterministic harness.
Risk and rollout
Use the matching SDK and plugin. Tool availability and vendor sign-in depend on the user’s environment. The offline walkthrough uses recorded inputs and requires no vendor account.
Public disclosure review