Skip to content

feat(plugin): guide Codex through scanner imports and workbench publication - #2604

Merged
mldangelo-oai merged 2 commits into
mainfrom
scanner-imports/agent-guidance
Nov 11, 2026
Merged

mldangelo-oai merged 2 commits into
mainfrom
scanner-imports/agent-guidance

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Codex can use a scanner executable, a hosted collector, a connected MCP tool, or a saved report to fulfill an import request. A later request to publish starts with the findings already in the workbench.

Review in order: #2602 → #2603 → #2604.

Changes

  • Give the agent concrete acquisition guidance for tools such as Trivy, Semgrep, Guardian and GitHub. Let it inspect available tools and write a parser when a built-in reader does not cover the export.
  • Route local imports and reviewed Cloud publication through the SDK. Preserve the existing CLI commands and flags.
  • Add routing examples, CLI help, diagrams and an offline Trivy and Guardian walkthrough. The published scanner-import workflow can use the same examples.

Testing

  • All 40 CLI help tests and 13 routing-harness tests passed after rebasing. Both compiled help entrypoints displayed the new guidance.

  • Ran the documented offline example with the built SDK, bundled plugin and real SQLite. It stored one Trivy finding and one Guardian finding, kept the exact selected Guardian ID, and recorded two imports and zero publications.

  • Exercised fresh Trivy, Semgrep and OpenGrep scans plus GitHub and SonarCloud API data. A parser written for a public advisory API imported five records with the installed SDK, preserved the original evidence on replay and rejected a stale selection after an upstream revision changed.

  • The native model-routing evaluation stopped before a model turn with HTTP 401. The routing checks above exercise the deterministic harness.

Risk and rollout

Use the matching SDK and plugin. Tool availability and vendor sign-in depend on the user’s environment. The offline walkthrough uses recorded inputs and requires no vendor account.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear acquisition-to-workbench workflow. This owner-level merge-safety review found no material issues in the stacked diff. The skill reuses the readers and SDK, retains exact selections and explicit Cloud upload approval, and documents retries against the approved finding versions.

Verified 40 CLI help tests, 13 routing-harness tests, nine portable compatibility tests, Ruff, focused formatting, TypeScript checking, SDK/plugin builds, and both compiled help entrypoints. The documented offline walkthrough also passed with real SQLite: two imports, the exact selected Guardian string ID, and zero publications. Live scanner/MCP acquisition and Cloud upload were not exercised.

@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/workbench-publication branch from 98bb6e2 to c50d6f5 Compare November 11, 2026 13:48
@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/agent-guidance branch from 5ea50c3 to 4022a78 Compare November 11, 2026 13:48

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the stored-publication calls and partial-import handling. This owner-level merge-safety re-review found no material issues in the updated ten-file stacked diff. The skill’s SDK calls, approval steps and partial-import exit status match the implementation.

On this head, 40 CLI help tests, 13 routing-harness tests, nine portable compatibility tests, SDK/plugin builds, type checking, Ruff and both compiled help entrypoints passed. The documented offline walkthrough also passed with real SQLite: two imports, the exact selected Guardian string ID, and zero publications. Live scanner/MCP acquisition and Cloud upload were not exercised.

@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/workbench-publication branch from c50d6f5 to b9540f4 Compare November 11, 2026 18:00
@mldangelo-oai
mldangelo-oai marked this pull request as ready for review November 11, 2026 18:21
@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/agent-guidance branch from 4022a78 to b343baa Compare November 11, 2026 18:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T18:51:06.825787Z 1f710a3 New commits
🔒 Security Review ✅ Completed 2026-11-11T18:54:08.151456Z 1f710a3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/agent-guidance branch from b343baa to ec6c591 Compare November 11, 2026 18:24

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks—this owner-level merge-safety re-review of ec6c5912 found no material issues in the ten-file stacked diff. The guidance matches the current SDK’s local import, exact version selection, approval and retry behavior.

Fresh verification passed 100 CLI/import tests, 13 routing-harness tests, nine portable compatibility tests, SDK/plugin builds, type checks and formatting. Both compiled help entrypoints and the documented offline walkthrough passed; real SQLite contained two imports, the exact selected Guardian string ID and zero publications. Live scanner/MCP acquisition, Cloud upload and model routing were not exercised.

Base automatically changed from scanner-imports/workbench-publication to main November 11, 2026 18:47
@github-actions github-actions Bot added the enhancement New feature or request label Nov 11, 2026
@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/agent-guidance branch from ec6c591 to e86764f Compare November 11, 2026 18:49
@mldangelo-oai
mldangelo-oai force-pushed the scanner-imports/agent-guidance branch from e86764f to 1f710a3 Compare November 11, 2026 18:49

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the scanner-import and workbench guidance. Owner-level merge-safety re-review of 1f710a3: no material findings in the ten-file diff. The acquisition guidance and updated collector examples match the current SDK and CLI. Publication uses stored finding versions, explicit preview approval, and existing receipt/retry handling.

Fresh verification passed 107 CLI/import tests, 13 routing-harness tests, nine portable compatibility tests, SDK/plugin builds, type checks, Ruff and formatting. Both compiled help entrypoints and the documented offline walkthrough passed; real SQLite contained two imports, the exact selected Guardian ID and zero publications. Live scanner/MCP acquisition, Cloud upload and model routing were not exercised.

@mldangelo-oai
mldangelo-oai merged commit a881fe1 into main Nov 11, 2026
74 checks passed
@mldangelo-oai
mldangelo-oai deleted the scanner-imports/agent-guidance branch November 11, 2026 19:14
@github-actions github-actions Bot mentioned this pull request Nov 11, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants