Repository navigation
fix(subos, luban): part 3 follow-ups -- the domain check asks inside the domain (J51) and says why for every refusal; an image boots on the monitor its home installs (J52) - #702
Merged
Conversation
…annot hand off included `subos __domain-check` printed what `domain_producer::prepare` refused bare, without "this host cannot build the domain at <home> ... (why)". luban shows that line when it keeps a system in place (J47). An unmarked build (main's asan lane) is such a refusal; the test now asserts the whole sentence on every host. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
…ere can be entered (J51) Verifying 2026.10.23.2 on a host whose own bwrap fails: `luban upgrade` asked `subos __domain-check /xlings`, which only ran `self init` in the namespace. It said yes; `subos new --rootfs` in the domain then saw only the host's broken bwrap (the domain does not carry the home's xim:bwrap), fell back to the prefix, and the move had already exported, removed and remade the system. The check now runs `__domain-check /xlings` inside the domain too, through the interface. For a home's own prefix that answers whether a root made here can be entered (`sandbox::root_host_ready`: the step making a root starts with, bwrap installed first where there is none, never asked). The domain's reason comes back in the one error. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
… time, as a machine's start does (J52) luban-os-ci L6-02: in a new home `luban enter <iso>` stopped at "booting an image needs a virtual machine monitor here -- xlings install qemu-system", while a machine's start installs xim:qemu-system itself. Both now take the same step (install_monitor_); the hint is said only when the install fails. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
Collaborator
|
Self-review (correctness, compatibility, UX, cross-platform):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #701 (part 3, J47). Two findings after 2026.10.23.2:
1. Main's asan shard 1/4 failed on b69aee2.
subos __domain-checkprinted adomain_producer::preparerefusal bare. An unmarked build, as in the asan lane, is one such refusal. Now every refusal for a private domain isthis host cannot build the domain at <home> in a private namespace (<why>). That is the line luban shows when it keeps a system in place.2. J51, found in the real verification of 23.2.
The host: its own
/usr/bin/bwrapfails, and the home uses its ownxim:bwrap. On it,luban upgrade vcoreworked (core 2026.10.20.1 → 2026.10.23.1, 0 notes), but it did not avoid the move:self initin the namespace, and that worked.subos new --rootfsinside the domain saw only the host's broken bwrap; the domain does not carry the home'sxim:bwrap. It stopped at the AppArmor setup question (exit 2) and fell back to the prefix, after the export.The fix:
self init, the check asks the domain, through the interface:__domain-check /xlingsin the domain's own home.__domain-checkanswers whether a root made here can be entered. That issandbox::root_host_ready: the step making a root starts with (xim:bwrapinstalled first where there is none, shared withprepare_root_host), never asked.3. J52, found by luban-os-ci's daily L6-02 on 23.2.
In a new home,
luban enter <iso>stopped at:A machine's start installs
xim:qemu-systemitself. Both now take the same step (install_monitor_), and the hint appears only when the install fails.AnImageBootsOnTheMonitorItsHomeInstallsTheFirstTime(requirementLUBAN-IMAGE-VMM) uses a fixture monitor. It fails without the fix and passes with it.docs/luban/05-images.md(en, zh) updated.Tests
ADomainCheckTriesTheNamespaceAsMakingASystemThereStartsasserts the whole sentence on every host.test_domain_producerand all oftest_luban(32) pass locally.DOM-CHECK-TRIEDtext updated.No version bump: it ships with the next release. Released 23.2 still moves such systems correctly, only at the cost of the archive. Labelled
ci:asanso the lane that failed runs here.Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com