Skip to content

fix: refetch recurring objects a search cut short - #867

Merged
tobixen merged 1 commit into
masterfrom
fix/search-drops-exceptions
Nov 14, 2026
Merged

tobixen merged 1 commit into
masterfrom
fix/search-drops-exceptions

Conversation

@tobixen

@tobixen tobixen commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Disclaimer: AI-generated code and text below the line, generated by Claude Opus 5.5


Bedework 3.10 and 5 leave the exceptions (the VEVENTs with a RECURRENCE-ID) out of the calendar-data of a calendar-query, while a GET has them, so a moved occurrence expanded on the client came back as a plain one.

  • New hint search.recurrences.exception.in-calendar-data, unsupported for both Bedeworks. There, search() fetches the recurring objects it found again in one multiget, but not after a server-side expansion, whose instances already carry the exceptions.
  • save-load.event.recurrences.exception is now full for both Bedeworks: the object keeps master and exception, it was only the search that left the exception out. On Bedework 5, expand=True therefore expands on the client again.
  • New CalendarObjectResource.load(fallbacks=False): the GET alone, with no multiget and no search by UID after a 404. caldav-server-tester needs it to compare a GET with a search (feat: probe whether a search keeps the exceptions caldav-server-tester#61, which re-probed both Bedeworks).

🤖 Generated with Claude Code

Bedework 3.10 and 5 leave the exceptions (the VEVENTs with a
RECURRENCE-ID) out of the calendar-data of a calendar-query, while a
GET has them.  Expanded on the client, a moved occurrence then comes
back as a plain one.  The new hint
search.recurrences.exception.in-calendar-data is unsupported for both,
and search() then fetches the recurring objects the search returned
again, in one multiget, unless the caller wrote the query or turned
the workarounds off.

Prompt: [fix it]
Followup-Prompt: I do not like the hint name.  Doesn't this belong under search.recurrences.expanded.exception ?
Followup-Prompt: rename it [to search.recurrences.exceptions: not under .expanded, since server expand works on Bedework]
Followup-Prompt: [Use search.recurrences.exception.in-calendar-data instead, beside the planned search.recurrences.exception.by-moved-dt for iCloud]

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
@tobixen
tobixen merged commit 2691c69 into master Nov 14, 2026
17 checks passed
tobixen added a commit that referenced this pull request Nov 14, 2026
caldav-server-tester graded save-load.event.recurrences.exception off a
search, and Bedework's searches leave the exception out.  Probed by a
GET, Bedework 3.10 and 5 keep both in one object, so the hint is full
for both.  On Bedework 5, search() then expands on the client again,
which search.recurrences.exception.in-calendar-data makes work.

Prompt: Please fix the caldav-server-tester probe [ref #867]

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen added a commit that referenced this pull request Nov 14, 2026
…erver expansion

#868

Follow-up to #867, merged
before these reached its branch.  Bedework 3.10 and 5 store the
exception with its master; load(fallbacks=False) loads by the GET
alone; and the reload from PR 867 no longer undoes a server-side
expansion.

Commits:
- e329979 fix: Bedework stores the exception with its master
- 2ef0063 feat: load(fallbacks=False) loads by the GET alone
- 7ff9b31 fix: keep a server expansion out of the reload

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant