Repository navigation
Conversation
The fix proposed in TODO_COMPATIBILITY_HINTS item 8 removes the skip of children with a default. Comparing every feature over all server profiles shows it marks working features unsupported, for instance sync-token.delete on Xandikos and Stalwart. Keep the derivation, say in the docstring of _derive_from_subfeatures that such a node answers from the type default, and close item 8 as won't fix with the results. Prompt: [pick from the task list: "Let grouping nodes without a default derive from children that have one"] Prompts (comments made inline in the document while reviewing it): > (on "no default" meaning both a grouping node and a real capability without a default) A real capability that has no default could have an explicit "unknown". > I think it was decided earlier that explicit defaults aren't important for leaf nodes, but for the parents an explicit default signifies that it's an independent feature that should be probed, without explcit (sic) default it's just a grouping node > but [leaving the behaviour as-is and documenting it] is probably good enough Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
setup_stalwart.sh read STALWART_USERNAME as a local part and created <name>@example.org, while StalwartTestServer used it as the whole login, so STALWART_USERNAME=foo set up one account and logged in as another. Both now take either a local part or a full address. Prompts: > fix [the review finding: STALWART_USERNAME means a local part to the > setup script and a full login to the client] Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Stalwart was the one docker test server without a README. It lists the credentials and environment variables, and explains the lowered WebDav.maxResults (50, set by STALWART_MAX_RESULTS): a test putting more objects than that in one calendar gets a 507 from Stalwart. Prompt: [Fix review findings] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
The description listed Stalwart as the server that also lists the collection itself on an initial sync; the CCS profile says the same. Prompt: [Fix review findings] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Negated searches (2.1) landed in v3.5.0 apart from server detection and functional tests; conflicts raise UidConflictError naming the holder (4.1); non-GET redirects, PROPFIND included, are followed on the same origin with a loop limit (4.3). Closed issues 71, 94, 612 and 680 are ticked. #750 #833 #837 Prompt: Please check all the checkboxes that should be checked [in the NLnet-funded roadmaps, while drafting payment requests] Assisted-By: Claude Opus 5.5 (Claude Code) Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/grouping-node-derive
branch
from
November 18, 2026 07:08
d8e2221 to
c39caaf
Compare
Its TLS certificate expired on 2026-11-14 and was not renewed, and the link check refuses every push touching the roadmap that links it. The link itself is fine; the exception goes once the site serves a valid certificate again. Prompt: what is the likelihood of devguide.calconnect.org being fixed soon? Perhaps add an exception, with a calendar-todo to follow up? Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
get_calendars() asks for supported-calendar-component-set, getctag and calendar-color in its depth-1 PROPFIND, but kept only the display name. A client wanting a calendar's component set then sent one PROPFIND per calendar: calendaring took 268 s for 469 calendars on a Synology server, against 6 s for the listing alone. Each Calendar now gets every property the listing answered in its props, and get_supported_components(use_cached=True) answers from there; a 404 property stays absent, so it is still fetched when asked for. Prompt: [pick from the task list: "calendaring: list collections with one PROPFIND, not one per calendar"] Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Bedework 5 lists a tasks/ calendar in the calendar home, display name and component set included, that answers 404 when asked directly. A client taking calendars from the listing alone, as the listing's properties now allow, would hand it out to fail on use. The new feature propfind.listed-members-exist records that, broken for Bedework 5 (3.10 lists no such calendar), so such a client can ask each listed calendar first only where it is needed. Prompt: so let's go for yet another caldav compatibility hint on the ghost collections Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Also piggy-backing, with their own commit messages:
perf: keep the listing's properties on calendars:get_calendars()keeps every property the listing PROPFIND answered, andget_supported_components(use_cached=True)answers from them. This takes calendaring'scollections()from one PROPFIND per calendar to one in all (268 s against 6 s for 469 calendars on a Synology server).feat: hint calendars a listing names but lacks: a new featurepropfind.listed-members-exist, broken for Bedework 5, whose listing names atasks/calendar that answers 404.