Repository navigation
Fix cache-key test on release branches - #58546
Closed
fabriziocucci wants to merge 1 commit into
Closed
fabriziocucci wants to merge 1 commit into
fabriziocucci wants to merge 1 commit into
Conversation
Summary: `getCacheKey` only hashes package contents when the package version ends in `-main`; published releases short-circuit and return the version string. The test asserted only the main-build property, so it could never pass on a release branch, where two calls with different package contents both return the version. The test now asserts the property that actually holds for each case: differing keys on main builds, and the version string on published releases. This also adds coverage for the published-release path, which previously had none. Changelog: [Internal] Differential Revision: D120209439
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120209439. |
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been merged in 6e862f9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
getCacheKeyonly hashes package contents when the package version ends in-main; published releases short-circuit and return the version string. Thetest asserted only the main-build property, so it could never pass on a release
branch, where two calls with different package contents both return the version.
The test now asserts the property that actually holds for each case: differing
keys on main builds, and the version string on published releases. This also
adds coverage for the published-release path, which previously had none.
Changelog: [Internal]
Differential Revision: D120209439