Skip to content

Fix cache-key test on release branches #58546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabriziocucci wants to merge 1 commit into from
Closed

Fix cache-key test on release branches #58546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions packages/react-native-babel-preset/src/__tests__/cache-key-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,19 @@ function getCacheKey(packageContents) {
return require('../index').getCacheKey();
}

test('cache key includes package metadata for main builds', () => {
expect(getCacheKey('{"dependency":"1.0.0"}')).not.toBe(
getCacheKey('{"dependency":"2.0.0"}'),
);
});
const {version: packageVersion} = require('../../package.json');

// Only `-main` versions hash package contents; published releases short-circuit
// to the version string, so each build asserts a different property.
if (packageVersion.endsWith('-main')) {
test('cache key includes package metadata for main builds', () => {
expect(getCacheKey('{"dependency":"1.0.0"}')).not.toBe(
getCacheKey('{"dependency":"2.0.0"}'),
);
});
} else {
test('cache key is the package version for published releases', () => {
expect(getCacheKey('{"dependency":"1.0.0"}')).toBe(packageVersion);
expect(getCacheKey('{"dependency":"2.0.0"}')).toBe(packageVersion);
});
}
Loading