Repository navigation
Make internal reactperflogger headers private (#58840) - #58840
Closed
j-piasecki wants to merge 2 commits into
Closed
j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123379537. |
meta-codesync
Bot
changed the title
reactperflogger headers privatereactperflogger headers private (#58840)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Switch `BridgeNativeModulePerfLogger.h`, `FuseboxTracer.h`, `FuseboxPerfettoDataSource.h`, `HermesPerfettoDataSource.h`, `ReactPerfetto.h` and `ReactPerfettoLogger.h` to `PrivateGuard.h`. `NativeModulePerfLogger.h` and `ReactPerfettoCategories.h` stay for frameworks. Changelog: [Internal] Differential Revision: D123379537
j-piasecki
force-pushed
the
export-D123379537
branch
from
October 5, 2026 10:37
e0c90aa to
6766ccf
Compare
cortinico
approved these changes
Oct 7, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Make `RuntimeExecutorSyncUIThreadUtils.h` private: switch it to `PrivateGuard.h` and drop it from the `<React/RuntimeExecutor.h>` umbrella. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123376642
Summary: Switch `BridgeNativeModulePerfLogger.h`, `FuseboxTracer.h`, `FuseboxPerfettoDataSource.h`, `HermesPerfettoDataSource.h`, `ReactPerfetto.h` and `ReactPerfettoLogger.h` to `PrivateGuard.h`. `NativeModulePerfLogger.h` and `ReactPerfettoCategories.h` stay for frameworks. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123379537
j-piasecki
force-pushed
the
export-D123379537
branch
from
October 9, 2026 07:40
6766ccf to
1db5baf
Compare
|
This pull request has been merged in 923bb33. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Switch
BridgeNativeModulePerfLogger.h,FuseboxTracer.h,FuseboxPerfettoDataSource.h,HermesPerfettoDataSource.h,ReactPerfetto.handReactPerfettoLogger.htoPrivateGuard.h.NativeModulePerfLogger.handReactPerfettoCategories.hstay for frameworks.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D123379537